Skip to content

docs(injective): apply spec feedback to PR #1235#1241

Open
JackReacher0807 wants to merge 1 commit intomainfrom
docs/openrpc/injective-feedback-1235
Open

docs(injective): apply spec feedback to PR #1235#1241
JackReacher0807 wants to merge 1 commit intomainfrom
docs/openrpc/injective-feedback-1235

Conversation

@JackReacher0807
Copy link
Copy Markdown
Collaborator

Follow-up to @andra-catana's #1235 addressing @daniel's review feedback.

What Daniel asked for

  1. Chain-level descriptions don't render anywhere useful. API reference pages are method-specific, not chain-specific — the expanded info.description and per-server descriptions in injective.yaml don't surface on the docs site. Move that prose onto the individual method definitions in _components/injective/methods.yaml where it actually renders on the method reference pages. Revert injective.yaml to the canonical minimal pattern used by every other chain spec.

  2. Debug API has its own dedicated OpenRPC spec. debug_* methods don't belong in a chain spec or its method components — they live in the Debug API product spec. Remove any debug_* definitions from the Injective chain components, remove debug_* refs from injective.yaml, and replace inline Debug documentation in the Injective MDX pages with a link to the Debug API docs.

What this PR changes (vs current main)

  • src/openrpc/chains/injective/injective.yaml

    • info.description back to A specification of the standard JSON-RPC methods for Injective. (canonical minimal form, matches every other chain).
    • servers entries carry only url and name; no description expansions.
    • Three method refs swapped to the new Injective-specific components file: eth_getBlockReceipts, eth_syncing, net_listening. Every other method still refs the shared _components/custom/methods.yaml or _components/evm/methods.yaml.
    • No debug_* refs present.
  • src/openrpc/chains/_components/injective/methods.yaml (new)

    • Three method overrides: eth_getBlockReceipts, eth_syncing, net_listening.
    • Each description adds an Injective-specific callout: "Enabled on Injective Testnet only. Not enabled on Injective Mainnet."
    • Params, results, schemas, and examples mirror the shared definitions so the method pages stay consistent with other EVM chains.
    • No debug_* definitions.
  • content/api-reference/injective/injective-api-overview.mdx

    • Keeps the useful network-identifier table (chain IDs in hex and decimal, block tags, explorer links) and the mainnet/testnet method split tables — those are the valuable parts of docs(injective): align Injective API docs with chain-config #1235.
    • The previous inline Debug method list is replaced with a short paragraph linking to /docs/reference/debug-api-quickstart and /docs/reference/debug-api-endpoints. Plan requirement is flagged there.
  • content/api-reference/injective/injective-api-faq.mdx

    • "What methods are supported" answer now clarifies the mainnet/testnet split, points out that eth_getBlockReceipts/eth_syncing/net_listening are testnet-only (each method page carries the full callout), and directs debug_* users to the Debug API docs.
  • content/api-reference/injective/injective-api-quickstart.mdx

    • Quickstart blurb mentions both mainnet (chain ID 0x6f0 / 1776) and testnet (0x59f / 1439), points at the overview for the full method list, and at the Debug API for debug_*.
    • Code example replaces a your-api-key reference with YOUR_API_KEY and adds a one-liner showing the Injective Testnet endpoint URL.

Daikon notes

  • injective.yaml — Daikon's updateSpecsFromDaikonWorkflow manages method refs and server endpoints but does not overwrite info.description or arbitrary fields we didn't touch. Reverting the description expansions is safe.
  • _components/injective/methods.yaml — manual territory. Daikon doesn't touch per-method definitions.
  • No x-bot-ignore entries added. No methods removed; this PR only relocates description prose and excludes debug_* (which the bot wouldn't have added here anyway).

Verification

pnpm run validate:rpc    # ✅ Successfully validated json-rpc OpenRPC specs
                         # ✅ Successfully validated chains OpenRPC specs
pnpm run generate:rpc    # ✅ All OpenRPC specs generated successfully!
pnpm run lint            # ✅ eslint clean, typecheck clean
                         # ⚠️  prettier warns on scripts/upload-specs.ts and
                         #     src/content-indexer/indexers/changelog.ts (both
                         #     untouched by this PR — pre-existing on main)

Confirmed in the compiled content/api-specs/chains/injective.json:

  • info.description is the minimal canonical string.
  • servers[*] have only url/name.
  • eth_getBlockReceipts, eth_syncing, net_listening carry the Injective testnet-only callout in their description.
  • methods.filter(m => m.name.startsWith('debug_')).length === 0.

Coordination

Andra and Daniel can merge whichever PR makes sense — this branch or a squash of this on top of #1235. The commit carries Co-authored-by: andra.catana <andra.catana@alchemy.com> so attribution survives either path.

Resolves the review feedback on #1235.

Follow-up to @andra-catana's #1235 addressing @daniel's review feedback.

1. Revert chain-level description expansion. The docs site does not consume
   info.description or per-server descriptions from chain OpenRPC specs — those
   don't surface on method reference pages. info.description is back to the
   canonical minimal form and server entries carry only url and name, matching
   every other chain spec.

2. Pull debug_* methods out of the chain spec. Debug namespace methods live in
   the dedicated Debug API product spec, not in chain specs. No debug_* refs
   exist in src/openrpc/chains/injective/injective.yaml and no debug_* method
   definitions exist in src/openrpc/chains/_components/injective/methods.yaml.

3. Move the useful network-coverage prose onto the individual method pages where
   it renders. src/openrpc/chains/_components/injective/methods.yaml overrides
   three methods (eth_getBlockReceipts, eth_syncing, net_listening) with an
   Injective-specific description callout noting testnet-only availability.
   The chain spec refs are updated to point at those overrides.

4. Inline Debug method tables removed from injective-api-overview.mdx and
   replaced with a short paragraph linking to /docs/reference/debug-api-quickstart
   and /docs/reference/debug-api-endpoints. injective-api-faq.mdx and
   injective-api-quickstart.mdx now mention that debug_* lives in the Debug API.

Verified: pnpm run validate:rpc ✅, pnpm run generate:rpc ✅, pnpm run lint ✅
(prettier warnings in two unrelated files, not touched here).

Co-authored-by: andra.catana <andra.catana@alchemy.com>
@JackReacher0807 JackReacher0807 requested a review from a team as a code owner April 20, 2026 18:54
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

🔗 Preview Mode

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview Apr 20, 2026, 6:54 PM

@github-actions
Copy link
Copy Markdown

🔍 Link Check

Status: ❌ Failed

Summary

Status Count
🔍 Total 7897
✅ Successful 6738
⏳ Timeouts 0
🔀 Redirected 402
👻 Excluded 676
❓ Unknown 0
🚫 Errors 80
⛔ Unsupported 1
Broken links (80) — click to expand

Errors per input

Errors in ./content/api-reference/op-mainnet/op-mainnet-api-faq/op-mainnet-api-faq.mdx

Errors in ./content/api-reference/arbitrum-nova/arbitrum-nova-deprecation-notice.mdx

Errors in ./content/wallets/pages/authentication/overview.mdx

Errors in ./content/wallets/pages/recipes/onramp-funds.mdx

Errors in ./content/api-reference/arbitrum/arbitrum-api-faq/arbitrum-api-faq.mdx

Errors in ./content/wallets/pages/bundler-api/bundler-faqs.mdx

Errors in ./content/changelog/2025-09-18.md

Errors in ./content/tutorials/alchemy-university/smart-contract-basics/multi-sig-contracts.mdx

Errors in ./content/api-reference/introduction/api-overview.mdx

Errors in ./content/wallets/pages/react-native/getting-started/getting-started-rn-bare.mdx

Errors in ./content/wallets/pages/concepts/smart-account-client.mdx

Errors in ./content/changelog/2026-04-09.md

Errors in ./content/changelog/2026-03-26.md

Errors in ./content/wallets/pages/react-native/getting-started/getting-started-expo.mdx

Errors in ./content/wallets/pages/recipes/smart-wallets-aave.mdx

Errors in ./content/api-reference/hyperevm/hyperevm-api-overview.mdx

Errors in ./content/api-reference/katana/katana-api-overview.mdx

Errors in ./content/wallets/pages/recipes/send-usdc.mdx

Errors in ./content/wallets/pages/recipes/upgrade-to-smart-accounts.mdx

Errors in ./content/wallets/pages/smart-wallets/how-to-stamp-requests.mdx

Errors in ./content/wallets/pages/index.mdx

Errors in ./content/wallets/pages/smart-wallets/quickstart/index.mdx

Errors in ./content/changelog/2025-08-28.md

View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants