fix(deployment): extend deploy progress overlay to cover the configure header#3380
fix(deployment): extend deploy progress overlay to cover the configure header#3380ygrishajev wants to merge 1 commit into
Conversation
…e header The overlay was positioned absolute inset-0 inside the panes content wrapper, a sibling that sits below the header, so during the deploying phase it covered only the panes and left the configure header (title, cost, deploy CTA) exposed. Wrap the header and panes in a shared relative container and render the overlay as its child so inset-0 spans the full configure surface, covering and intercepting clicks on the header while deploying, matching the onboarding deploy-progress layout.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRestructures the DOM layout in ConfigureDeploymentForm layout restructure
🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3380 +/- ##
==========================================
- Coverage 69.81% 68.44% -1.37%
==========================================
Files 1100 1010 -90
Lines 26925 24592 -2333
Branches 6455 5997 -458
==========================================
- Hits 18797 16833 -1964
+ Misses 7134 6797 -337
+ Partials 994 962 -32
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
Why
The configure deploy-progress overlay was meant to be full-screen, but it covered only the panes —
leaving the configure header (title, deployment cost, Deploy CTA) visible and clickable while deploying.
That makes the deploying state look half-finished and lets users hit stale header controls mid-deploy.
Part of CON-425.
What
A layout-only fix on the configure screen so the deploy-progress overlay covers the whole surface:
absolute inset-0inside the panes' content wrapper — a sibling that sitsbelow the header — so
inset-0could only ever span the panes.relativecontainer and movedDeployProgressOverlayto beits child.
inset-0now spans the full configure surface (everything below the global account bar), sothe opaque overlay covers and intercepts clicks on the header while deploying, and the progress panel's
pt-[80px]measures from the true top of the surface — matching the onboarding deploy-progress layoutthe overlay was modeled on.
relativewrapper is preserved, so nothing inside the panes shifts.No behavior change outside the deploying phase. No API/SDL changes, no breaking changes, no migrations.
Testing
engine, and asserting the wrapper markup would be a brittle structure test — so it's verified visually
via the deploying-phase walkthrough.
ConfigureDeploymentFormandDeployProgressOverlayunit specs still pass (no regression);lint and type-check are clean for the changed file.
Summary by CodeRabbit