Skip to content

fix(deployment): extend deploy progress overlay to cover the configure header#3380

Open
ygrishajev wants to merge 1 commit into
mainfrom
fix/deployment-progress-overlay-covers-header
Open

fix(deployment): extend deploy progress overlay to cover the configure header#3380
ygrishajev wants to merge 1 commit into
mainfrom
fix/deployment-progress-overlay-covers-header

Conversation

@ygrishajev

@ygrishajev ygrishajev commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Why

The configure deploy-progress overlay was meant to be full-screen, but it covered only the panes —
leaving the configure header (title, deployment cost, Deploy CTA) visible and clickable while deploying.
That makes the deploying state look half-finished and lets users hit stale header controls mid-deploy.

Part of CON-425.

What

A layout-only fix on the configure screen so the deploy-progress overlay covers the whole surface:

  • The overlay was positioned absolute inset-0 inside the panes' content wrapper — a sibling that sits
    below the header — so inset-0 could only ever span the panes.
  • Wrapped the header and panes in one shared relative container and moved DeployProgressOverlay to be
    its child. inset-0 now spans the full configure surface (everything below the global account bar), so
    the opaque overlay covers and intercepts clicks on the header while deploying, and the progress panel's
    pt-[80px] measures from the true top of the surface — matching the onboarding deploy-progress layout
    the overlay was modeled on.
  • The panes' own relative wrapper is preserved, so nothing inside the panes shifts.

No behavior change outside the deploying phase. No API/SDL changes, no breaking changes, no migrations.

Testing

  • This is a CSS/positioning occlusion change. It isn't meaningfully unit-testable — jsdom has no layout
    engine, and asserting the wrapper markup would be a brittle structure test — so it's verified visually
    via the deploying-phase walkthrough.
  • Existing ConfigureDeploymentForm and DeployProgressOverlay unit specs still pass (no regression);
    lint and type-check are clean for the changed file.

Summary by CodeRabbit

  • Refactor
    • Adjusted the deployment configuration page layout for a cleaner, more consistent structure.
    • Updated spacing and container behavior around the header and configuration panes without changing any visible form fields or actions.

…e header

The overlay was positioned absolute inset-0 inside the panes content wrapper, a
sibling that sits below the header, so during the deploying phase it covered only the
panes and left the configure header (title, cost, deploy CTA) exposed.

Wrap the header and panes in a shared relative container and render the overlay as its
child so inset-0 spans the full configure surface, covering and intercepting clicks on
the header while deploying, matching the onboarding deploy-progress layout.
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b3c48816-77d0-4367-ac89-edd1da166001

📥 Commits

Reviewing files that changed from the base of the PR and between b6fecee and b811d29.

📒 Files selected for processing (1)
  • apps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigureDeploymentForm/ConfigureDeploymentForm.tsx

📝 Walkthrough

Walkthrough

Restructures the DOM layout in ConfigureDeploymentForm by adding an outer flex-col wrapper div around ConfigureDeploymentHeader and ConfigureDeploymentPanes, and nesting the header inside a dedicated px-6 pt-6 padding div. No props or component logic changed.

ConfigureDeploymentForm layout restructure

Layer / File(s) Summary
Flex-column wrapper and header padding
apps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigureDeploymentForm/ConfigureDeploymentForm.tsx
Outer relative flex min-h-0 flex-1 flex-col div wraps both header and panes; header moves into a px-6 pt-6 inner div; panes remain in relative mt-6 flex min-h-0 flex-1.

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deployment-progress-overlay-covers-header

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.44%. Comparing base (b6fecee) to head (b811d29).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3380      +/-   ##
==========================================
- Coverage   69.81%   68.44%   -1.37%     
==========================================
  Files        1100     1010      -90     
  Lines       26925    24592    -2333     
  Branches     6455     5997     -458     
==========================================
- Hits        18797    16833    -1964     
+ Misses       7134     6797     -337     
+ Partials      994      962      -32     
Flag Coverage Δ *Carryforward flag
api 85.13% <ø> (ø) Carriedforward from b6fecee
deploy-web 55.02% <ø> (ø) Carriedforward from b6fecee
log-collector ?
notifications 91.44% <ø> (ø) Carriedforward from b6fecee
provider-console 81.38% <ø> (ø) Carriedforward from b6fecee
provider-inventory ?
provider-proxy 86.26% <ø> (ø) Carriedforward from b6fecee
tx-signer ?

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...onfigureDeploymentForm/ConfigureDeploymentForm.tsx 96.92% <ø> (ø)

... and 90 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants