Skip to content

ci: build autoscaler-webhook example image for e2e tests #4810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lacroixthomas merged 2 commits into from
Oct 29, 2026
+7 −6
Merged

ci: build autoscaler-webhook example image for e2e tests #4810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13b8aaf
ci: build autoscaler-webhook example image for e2e tests
markmandel Oct 28, 2026
0c37fa4
Merge branch 'main' into e2e/build-rest-of-images
lacroixthomas Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/push-e2e-example-images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ examples=(
"rust-simple|rust-simple-server|version|sdks/rust"
"cpp-simple|cpp-simple-server|version|sdks/cpp .dockerignore"
"nodejs-simple|nodejs-simple-server|version|sdks/nodejs .dockerignore"
"autoscaler-webhook|autoscaler-webhook|version|pkg go.mod go.sum .dockerignore"
)

push_example() {
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/fleetautoscaler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ func defaultAutoscalerWebhook(namespace string, fixedReplicasEnabled string) (*c
Containers: []corev1.Container{
{
Name: "webhook",
Image: "us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.23",
Image: framework.ExampleImage("autoscaler-webhook", "0.23"),
ImagePullPolicy: corev1.PullIfNotPresent,
Ports: []corev1.ContainerPort{{
ContainerPort: 8000,
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/framework/framework.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@ func NewFromFlags() (*Framework, error) {

pflag.String(kubeconfigFlag, viper.GetString(kubeconfigFlag), "kube config path, e.g. $HOME/.kube/config")
pflag.String(gsimageFlag, viper.GetString(gsimageFlag), "gameserver image to use for those tests")
pflag.String(exampleImageRegistryFlag, viper.GetString(exampleImageRegistryFlag), "registry of the example images to use for the examples tests")
pflag.String(exampleImageTagFlag, viper.GetString(exampleImageTagFlag), "optional tag of the example images to use for the examples tests; if empty, the published version of each example image is used")
pflag.String(exampleImageRegistryFlag, viper.GetString(exampleImageRegistryFlag), "registry of the example images to use for the e2e tests")
pflag.String(exampleImageTagFlag, viper.GetString(exampleImageTagFlag), "optional tag of the example images to use for the e2e tests; if empty, the published version of each example image is used")
pflag.String(pullSecretFlag, viper.GetString(pullSecretFlag), "optional secret to be used for pulling the gameserver and/or Agones SDK sidecar images")
pflag.Int(stressTestLevelFlag, viper.GetInt(stressTestLevelFlag), "enable stress test at given level 0-100")
pflag.String(perfOutputDirFlag, viper.GetString(perfOutputDirFlag), "write performance statistics to the specified directory")
Expand Down
6 changes: 3 additions & 3 deletions test/e2e/gameserver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1490,7 +1490,7 @@ func TestGameServerPodTemplateSpecFailSchemaValidation(t *testing.T) {
// The schema's from Kubernetes don't include anything like `pattern:` or `enum:` which would
// potentially make this easier to test.

gsYaml := `
gsYaml := fmt.Sprintf(`
apiVersion: "agones.dev/v1"
kind: GameServer
metadata:
Expand All @@ -1507,8 +1507,8 @@ spec:
preferredDuringSchedulingIgnoredDuringExecution: ERROR
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.44
`
image: %s
`, framework.GameServerImage)
err := os.WriteFile("/tmp/invalid.yaml", []byte(gsYaml), 0o644)
require.NoError(t, err)

Expand Down
Loading