Repository navigation
Conversation
|
🔴 Contributor Check: HIGH
Automated check by AgenTrust Contributor Check. |
dinakarjs
left a comment
There was a problem hiding this comment.
Reviewed dca38a8. The 197 committed trace-adapter tests pass locally on Linux/Python 3.12.14, but an independent synthetic negative control establishes a verification-boundary failure outside the committed suite. Please hold acceptance pending private triage and an exact-head regression review.
I am withholding the input and reproduction from this public thread under SECURITY.md. The private report and executable reproducer are prepared, but not yet submitted: the available GitHub connector does not support advisory creation and the browser requires sign-in. This review does not claim that maintainers have received the private details. No published-release impact has been established; the finding is reproduced in this proposed library slice. Prepared with OpenAI Codex.
|
Status correction to my earlier review: the private report was successfully submitted on 14 November and I have now verified that it is in maintainer triage. The statement that it was not yet submitted is historical. The reviewed public head remains dca38a8; my changes request remains in place pending private disposition and review of the correction. No private reproduction details are disclosed here, and no released-version impact or resolution is claimed. Prepared with OpenAI Codex. |
…ture assertions Extract the section 3.3.4 verifier into agentrust-trace-adapters. Missing evidence stays receipt_missing_required, a two-sided splice is receipt_gap_disclosed, and a tail disclosure stays gap_disclosure_unverified. Credential coverage uses an explicit inventory. cause and fencing epochs do not authorize retry. Signed-off-by: Raghuvar Karthik Durga <177662415+drk-ram@users.noreply.github.com>
…redential conflicts - Require the sealing successor (and the terminal hop receipt after a consecutive disclosure run) to carry a valid signature in session_id under the chain key / authenticated ancestor with strictly increasing sequence before treating a GapDisclosure/1.0 as sealed. - Require hops in reconcile_chain to form a contiguous hash-linked, monotonically sequenced chain under the chain key / authorized ancestor; unlinked or foreign-key hops fail closed as receipt_invalid. - Reject disclosures that claim a credential_id also present as a hop receipt (or duplicated across disclosures) as disclosure_contradicted. Signed-off-by: Raghuvar Karthik Durga <177662415+drk-ram@users.noreply.github.com>
|
@dinakarjs Rebased onto current
|
dca38a8 to
0478f1c
Compare
Summary
Library extraction for the
GapDisclosure/1.0verifier, scoped to the contract review on #416.reconcile_chainandverify_disclosurelive inagentrust-trace-adapters. Splice facts are derived from authenticated chain elements. Fixture booleans are not API inputs.This does not change
ca2a_verifyor cMCP emission. Retry stays unauthorized.effect_statusstaysunknown.Closes #416
Contract review
receipt_missing_required. Case B isreceipt_gap_disclosedonly with a verified Ed25519 issuer, stream binding, and a two-sided splice. A tail disclosure isgap_disclosure_unverified: not coverage, and not invalid.expected_credential_ids.chain[:2]does not infer a third hop. A disclosure covers an inventory entry only when its signedcredential_idbinds that entry.causeandreceipts_lost_estimateare validated and echoed. Alease_idincause, or an emitter-assertedcas_fence_epoch, does not select an outcome or authorize retry. A second hop for the same credential isreceipt_invalid.predecessor_present,successor_present,permitted_ancestor_key_ids, orclaimed_absent_but_present. Those facts are derived. Ancestor entitlement requires aKeyHierarchy/1.0element signed by the ancestor key. Untrusted JSON is size-bounded and rejects duplicate keys, non-finite numbers, and non-integral numbers. The twenty section 3.3.4 vectors and the live-tail contrast are preserved, with consumer cases for A/B/tail, truncated inventory, contradiction, unauthorized signers, and descriptive-field invariance.KeyHierarchy/1.0is this library's ancestor carrier. It is not a TRACE record type and not aca2awire change.Test plan
python -m pytest packages/agentrust-trace-adapters/tests -q— 197 passedruff checkon the new module, package init, and tests (E4,E7,E9,F,--target-version py39) — passedpython scripts/validate_integrations.py— 51 integrations, 0 failurespython -m pytest tests/test_validate_integrations.py tests/test_composite_action_paths.py tests/test_workflow_oidc_permissions.py tests/test_integration_schema.py -q— 48 passedpython scripts/validate_compatibility.py— 0 failurespython -m pytest tests/test_validate_compatibility.py tests/test_generate_marketplace_catalog.py tests/test_generate_agt_marketplace_catalog.py -q— 12 passedpython scripts/generate_integration_index.py --check— passedpython scripts/generate_marketplace_catalog.py --check— catalog currentpython -m unittest discover -s testsinintegrations/agentrust-confidential-workflow-harness— 28 in-repo tests passed; 10 modules did not import locally becauseca2a_runtime,cmcp_runtime, andtrace_testsare not installed. Unrelated to this change.No
.github/pull_request_template.mdis present in this repository.