Skip to content

test(e2e): keep #327 adapter-authoring coverage after #363 - #364

Merged
ankitranjan7 merged 1 commit into
mainfrom
fix/311-adapter-authoring-e2e
Aug 19, 2026
Merged

test(e2e): keep #327 adapter-authoring coverage after #363#364
ankitranjan7 merged 1 commit into
mainfrom
fix/311-adapter-authoring-e2e

Conversation

@ankitranjan7

Copy link
Copy Markdown
Contributor

Replacement for #327 now that #363 is on main.

Why not merge #327 as-is

#327 wraps site * and adapter path/source so they print Error: … and set exitCode. After #363 that is:

  • Redundant locallyrunCli already catches and emits the shared envelope (exit 2 / 66).
  • Wrong in hosted moderunHostedSiteSurface uses the same registerSiteCommands. wrapAction swallows the throw, so hosted reports success instead of the envelope.

#327 is also based on pre-#361/#363 main and would reintroduce browser fork and drop profile list -f.

What this keeps

The useful part of #327: e2e coverage for the local-mode #311 checklist (override/source/reset, site memory, browser init/verify, mutable files). Assertions updated for the envelope (ok: false) instead of Error:.

Test plan

  • npm run typecheck
  • npx vitest run --project e2e tests/e2e/adapter-authoring-parity.test.ts (28 passed)

Closes the local-mode remainder of #327. Hosted wrap is not needed.

Keep #327's local-mode checklist after #363. Drop wrapAction — runCli and
the hosted runner already envelope these throws, and swallowing them would
mark hosted site errors as success.
@github-actions

Copy link
Copy Markdown
Contributor

🟢 No documentation gap found — medium confidence

The automated review found no documentation gap in the supplied changes.

This review is advisory and does not block merging.

@ankitranjan7
ankitranjan7 merged commit 6d040e8 into main Aug 19, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant