test(e2e): keep #327 adapter-authoring coverage after #363 - #364
Merged
Conversation
4 tasks
Contributor
🟢 No documentation gap found — medium confidenceThe automated review found no documentation gap in the supplied changes. This review is advisory and does not block merging. |
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #327 now that #363 is on
main.Why not merge #327 as-is
#327 wraps
site *andadapter path/sourceso they printError: …and setexitCode. After #363 that is:runClialready catches and emits the shared envelope (exit 2 / 66).runHostedSiteSurfaceuses the sameregisterSiteCommands.wrapActionswallows the throw, so hosted reports success instead of the envelope.#327 is also based on pre-#361/#363
mainand would reintroducebrowser forkand dropprofile list -f.What this keeps
The useful part of #327: e2e coverage for the local-mode #311 checklist (override/source/reset, site memory,
browser init/verify, mutable files). Assertions updated for the envelope (ok: false) instead ofError:.Test plan
npm run typechecknpx vitest run --project e2e tests/e2e/adapter-authoring-parity.test.ts(28 passed)Closes the local-mode remainder of #327. Hosted wrap is not needed.