fix: surface tool load errors in get_tool fallback - #1845
Open
vanja-emichi wants to merge 1 commit into
Open
Conversation
get_tool silently swallows exceptions raised while loading a tool module and falls back to the Unknown tool. When a plugin tool fails to import (e.g. a stale module cache or a missing symbol), the only visible symptom is the generic 'tool not found' message, which sends users debugging the tool name instead of the actual import error. Log the failing path and error to the console before continuing to the next candidate, so the real cause is visible at dispatch time. No behavioral change otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Agent.get_toolsilently swallows any exception raised while loading a tool module and falls back to theUnknowntool. When a plugin tool failsto import (e.g. a stale module cache or a missing symbol), the only visible symptom is
the generic "tool not found" message, which sends users debugging the tool name
instead of the actual import error.
I hit exactly this while developing a plugin: a helper module cached in
sys.modules