feat(chat): edit user messages inline - #707
Closed
Zhangs-11 wants to merge 1 commit into
Closed
Conversation
Zhangs-11
force-pushed
the
feat/inline-message-edit
branch
from
September 5, 2026 10:28
70b6b02 to
f6d90e9
Compare
Zhangs-11
added a commit
to Zhangs-11/pi-web
that referenced
this pull request
Sep 5, 2026
Zhangs-11
force-pushed
the
feat/inline-message-edit
branch
from
September 5, 2026 10:52
f6d90e9 to
9596cd1
Compare
Zhangs-11
added a commit
to Zhangs-11/pi-web
that referenced
this pull request
Sep 5, 2026
Owner
|
Thanks for the contribution. The existing "Edit from here" flow already covers editing and resending messages, so we'd prefer to improve that flow (including first-message support) rather than maintain a separate inline editor. Closing this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Escapeto cancel, andCtrl/Cmd+Enterto submitThe session JSONL remains append-only. Older branches stay available through the existing branch navigator, while the active chat view shows only the revised message and its new response. No additional sidebar session is created.
This addresses the editing portion of #628.
Implementation notes
navigate_treereturns the resulting active leaf so the client can reload the exact parent context before resendingTesting
npm test— 892 tests passednode_modules/.bin/tsc --noEmitnpm run lintDemo
The demo edits the first active user message and reruns it through the real model flow.
Recorded from
Zhangs-11/pi-web@9596cd11e895d44e908fca2d9655f224c10ca93don the clean rebased branch, served athttp://127.0.0.1:30159withnext devbecause repository instructions prohibitnext buildduring development. The run used a fresh isolated Pi agent directory, workspace, and headless Chrome profile with the normal application transport; the repository-declared Playwright CDP fallback was used after agent-browser could not connect to its configured CDP endpoint. Real GPT-6-Astra rounds produced both the original and updated answers; no fixtures, mock transport, DOM-event injection, or test-only hooks were used.