Skip to content

fix: restore Windows drive roots in file routes - #703

Open
y4ho0 wants to merge 1 commit into
agegr:mainfrom
y4ho0:fix/windows-drive-root-file-browser
Open

fix: restore Windows drive roots in file routes#703
y4ho0 wants to merge 1 commit into
agegr:mainfrom
y4ho0:fix/windows-drive-root-file-browser

Conversation

@y4ho0

@y4ho0 y4ho0 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #702

Summary

  • Treat a bare drive-letter route segment such as D: as the corresponding drive root D:/.
  • Use the reconstructed path for both file reads and uploads.
  • Add regression coverage for drive roots while preserving existing Windows subdirectory and POSIX path behavior.

Security

The reconstructed path still passes through the existing allowed-root and real-path containment checks. This change only corrects the drive-root representation; it does not grant access to additional filesystem locations.

Verification

  • npm test — 845 passed
  • node_modules/.bin/tsc --noEmit
  • npm run lint -- --quiet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] File browser shows "Access denied" when session working directory is a Windows drive root (e.g. D:\)

1 participant