feat: add workspace terminal tabs to the file panel - #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add workspace terminals as tabs alongside files in the existing right panel, opened from the Explorer toolbar. Each tab keeps its original cwd and shell while switching files, chat sessions, or projects. Terminal tabs show their workspace name and support keyboard navigation.
Saved tab IDs reconnect to the same PTY after a page refresh. Unclaimed creations and terminals with no connected clients expire after a 120-second grace period. Explicit close and restart wait for the creation request and in-flight input before deleting the old terminal; shell exits retain output and show the exit code. Expired tabs do not silently launch replacement shells.
Validation
npm cion macOS ARM64, including native PTY startupnode_modules/.bin/tsc --noEmit --incremental falsenpm run lintnpm run test:terminal: Chromium at 1440x900 and 390x844; real shell input, file/session/workspace switching, refresh, offline reconnect, restart, exit codes, and closing during creationCloses #507