Skip to content

[CLIENT-5055] Document breaking changes for write, operate, apply, batch write, and batch apply policies' "key" option that now uses union precedence - #1154

Merged
juliannguyen4 merged 29 commits into
devfrom
CLIENT-5055-document-send_key-breaking-changes
Jul 22, 2026
Merged

[CLIENT-5055] Document breaking changes for write, operate, apply, batch write, and batch apply policies' "key" option that now uses union precedence#1154
juliannguyen4 merged 29 commits into
devfrom
CLIENT-5055-document-send_key-breaking-changes

Conversation

@juliannguyen4

@juliannguyen4 juliannguyen4 commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

This affects the "key" option for these policies across dynamic config (wherever applicable), client config, and command level policies

Manual testing

  • Build artifacts passes
  • Valgrind shows no memory errors or leaks from these changes
  • Massif mem usage looks ok

TODO

  • ToString double check the docstring looks correct..

https://aerospike-python-client--1154.org.readthedocs.build/en/1154/client.html#write-policies

@juliannguyen4 juliannguyen4 changed the title [CLIENT-5055] Document breaking changes for write, operate, and batch write policies' "key" option that now uses union policy instead of normal precedence [CLIENT-5055] Document breaking changes for write, operate, and batch write policies' "key" option that now uses union precedence Jul 15, 2026
@juliannguyen4
juliannguyen4 changed the base branch from dev to CLIENT-5057-document-string-ops-behavior-when-bin-is-missing July 15, 2026 22:27
@codecov-commenter

codecov-commenter commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.38%. Comparing base (2aefebd) to head (0cb7324).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1154   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         101      101           
  Lines       14608    14608           
=======================================
  Hits        12473    12473           
  Misses       2135     2135           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliannguyen4 juliannguyen4 changed the title [CLIENT-5055] Document breaking changes for write, operate, and batch write policies' "key" option that now uses union precedence [CLIENT-5055] Document breaking changes for write, operate, apply, batch write, and batch apply policies' "key" option that now uses union precedence Jul 15, 2026
…n. I'm not sure if read policy would cause read commands to store the user key, and sending the key for remove/batch_remove doesn't make sense to me. TODO - apply/batch_apply policies hasn't been finished yet
…s union precedence now that the tests have verified that behavior.
…apply, batch_write, and batch_apply policies.
…ly inherit from config level policy options if the latter is not passed as an argument.
… applied when config level policy sends the key but command level policies overrides that option to false
…ser key but not a specific value. only remove keys that were inserted during teardown
…recedence.py use a unique set name. This makes sure each test case performs a query that cannot pick up leftover keys from previous tests.
… that aren't declared in the dynamic config's yaml schema and addresses the warnings reported in the client logs re: this.
… the side effects can be inspected after a test run that uses a unique set name
@juliannguyen4
juliannguyen4 force-pushed the CLIENT-5055-document-send_key-breaking-changes branch from 1b2d3a8 to 87f3193 Compare July 20, 2026 21:22
@juliannguyen4
juliannguyen4 changed the base branch from CLIENT-5057-document-string-ops-behavior-when-bin-is-missing to dev July 20, 2026 21:23
@juliannguyen4
juliannguyen4 marked this pull request as ready for review July 20, 2026 21:33
@juliannguyen4
juliannguyen4 merged commit bc15a32 into dev Jul 22, 2026
132 of 133 checks passed
@juliannguyen4
juliannguyen4 deleted the CLIENT-5055-document-send_key-breaking-changes branch July 22, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants