Repository navigation
IgnoresAccessChecksToOmitAttributeDefinition & other fixes - #29
Merged
aelij merged 7 commits intoJul 5, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add support for MSBuild property IgnoresAccessChecksToOmitAttributeDefinition
Add Jul 5, 2026
IgnoresAccessChecksToOmitAttributeDefinition MSBuild property
…roperty-ignoresaccesscheckstoomitattr
aelij
marked this pull request as ready for review
July 5, 2026 20:18
IgnoresAccessChecksToOmitAttributeDefinition MSBuild property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new MSBuild property to suppress emission of the
IgnoresAccessChecksToAttributeclass definition — useful when the attribute is already declared elsewhere (e.g. by another package) and you'd otherwise get a duplicate type error.Usage
When set, the generated file still contains the
[assembly: ...]attribute usages but omits the class definition.Changes
PublicizeInternals.cs— addsOmitAttributeDefinitionbool task property; extracts content generation intointernal static BuildAttributeFileContent()which conditionally omits the class definitionIgnoresAccessChecksToGenerator.targets— wires$(IgnoresAccessChecksToOmitAttributeDefinition)→OmitAttributeDefinitionon the task invocationtest/IgnoresAccessChecksToGenerator.Tasks.Test/— new xUnit project with 4 tests covering default and omit behaviors for single and multiple assembly namesREADME.md— documents the new property with an example