Refresh served datasets after an import - #2722
Merged
Merged
Conversation
An overwrite import left the dataset pinned and cached at startup in service, so reads could be answered from a plan predating the import, and a schema-changing rewrite made any recache of that plan fail. Refresh the data source for each imported resource type on completion, as updates already do.
…ree-issue-2714-overwrite-import-stale
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2714. An overwrite $import left the dataset pinned and cached at startup in service, so reads could be answered from a plan predating the import, and a schema-changing rewrite made any recache of that stale plan fail - the cause of the intermittent
DELTA_SCHEMA_CHANGE_SINCE_ANALYSISfailure inNarrowedOpenTypesIT.importInOverwriteModeRewritesAtTheEncoderSchema. The import path now callsDynamicDeltaSource.refresh()for each imported resource type on completion, as updates already do, unpersisting the stale cached dataset and re-pinning the current table.