Tolerate concurrent job deletion in integration test teardown - #2720
Merged
Conversation
Cancelling a job deletes its directory asynchronously, so a test teardown sweeping the jobs directory can race the server and fail with NoSuchFileException. Provide a cleanup helper that treats a concurrently deleted entry as already cleaned up.
ExportOperationIT.cleanup raced the server's asynchronous deletion of a cancelled job's directory, failing intermittently with NoSuchFileException. Switch the job directory teardowns to the tolerant cleanup helper. Resolves #2711.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2711.
ExportOperationIT.cleanupswept the jobs directory withFileUtils.cleanDirectorywhile the server deleted a cancelled job's directory asynchronously, so overlapping deletions failed the teardown intermittently withNoSuchFileException. This adds a teardown helper that treats an entry disappearing mid-cleanup as already cleaned up, and switchesExportOperationIT,JobListIT(which cancels jobs and shares the identical race) andExportOperationCacheIT(same pattern) over to it.