Assert the enumeration fallback logs a warning - #2717
Merged
Conversation
The fallback test verified the behaviour but not the warning, so the logging half of the contract could regress silently. Capture the log events and require a WARN naming the failed listing. Resolves #2712.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2712.
DynamicDeltaSourceTest.enumerationFallsBackWhenListingFailsverified that a failed warehouse directory listing falls back to the known resource types, but never asserted that the accompanying warning was emitted, so that half of the behaviour could regress silently. The test now captures the log events and requires a WARN naming the failed listing. Verified by temporarily removing the warning fromDynamicDeltaSourceand observing the strengthened assertion fail.