Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The optimizer-dependent performance change needs query-plan and timing validation on the affected database plus UI5 regression testing, but CodeQL execution was unavailable in this review environment.
No open issues 🎉
What changed in this PR
Refactors UI5 JSON-file model resolution to improve query evaluation performance while preserving the existing binding-path logic.
Changes:
- Extracts constructor URI resolution into a private
noinlinehelper. - Moves JSON-file binding resolution into a separate
noinlinehelper called bygetModelNode.
| File | Description |
|---|---|
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5DataModels.qll |
Isolates JSON-file resolution in two helpers to control inlining and improve performance. |
Review effort: Balanced
mbaluda
marked this pull request as ready for review
November 9, 2026 12:50
Inline model-name matching to retain receiver constraints and centralize explicit setModel checks in SetModelCall. Add focused call-recognition coverage using existing fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Unavailable unit-test and UI5 model/XSS regression results, along with representative database timings, leave the QL inlining/materialization changes’ correctness and performance benefits unverified.
No open issues 🎉
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how JSON model content is resolved for UI5 binding paths, improving code clarity and performance on certain database