Skip to content

chore: standardize on Node.js 24 LTS for local, CI, and Vercel - #13

Open
aduquehd wants to merge 1 commit into
mainfrom
chore/node-24
Open

aduquehd wants to merge 1 commit into
mainfrom
chore/node-24

Conversation

@aduquehd

Copy link
Copy Markdown
Owner

What

Runs the project on Node.js 24 LTS (24.22.1) everywhere: locally, in CI, and in Vercel builds and functions.

Why

Local development already ran on Node 24 through fnm, but CI and the Vercel project were still on 22.x. Vercel deprecates Node 20 on 2026-10-01, and 24 is now its default LTS. Using one runtime everywhere means CI and production behave like local.

Changes

  • .node-version (new): pins 24.22.1. fnm reads it locally, and CI reads it through setup-node's node-version-file.
  • package.json: changes engines.node from >=20.19.0 to 24.x. Vercel reads this when it builds and runs functions.
  • .github/workflows/ci.yml: both jobs (check and e2e) get their Node version from .node-version instead of hard-coding 22.x.
  • @types/node: moves from ^26.3.0 to ^24.19.2 so the types match the runtime. On 26, code could use Node 26-only APIs that pass the type check and then crash on 24.
  • Vercel project setting: changed json-formatter's Node.js version from 22.x to 24.x in the dashboard, so it agrees with engines. That change is not part of this diff.

Verified on Node 24.22.1: pnpm check passes (545 unit tests, 0 errors) and so does pnpm test:e2e (25 passed, 2 skipped). After pnpm dedupe the lockfile still has a single @codemirror/state.

🤖 Generated with Claude Code

- Add .node-version (24.22.1) as the single source of truth; fnm reads
  it locally and CI reads it via setup-node's node-version-file.
- Set engines.node to 24.x so Vercel builds and functions run on 24.
- Align @types/node to ^24 so types match the runtime and can't
  expose Node 26-only APIs that would fail on 24 at runtime.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
json-formatter Ready Ready Preview Oct 22, 2026 10:02pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — e3e40250 Deployed Oct 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant