Skip to content

Revert CA cert sub-directory processing in Linux entrypoints - #1032

Merged
gdams merged 8 commits into
mainfrom
copilot/revert-ca-certs-sub-dir-support
Aug 14, 2026
Merged

gdams merged 8 commits into
mainfrom
copilot/revert-ca-certs-sub-dir-support

Conversation

Copilot AI commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

The July image publish is blocked downstream because the CA cert sub-directory support introduced in PR #955 expands the generated image diffs beyond what docker-library/official-images will accept. This change manually reverts that behavior in the current entrypoints while preserving unrelated later certificate-handling fixes.

  • Entrypoint behavior

    • Restore CA import scope to top-level /certificates/*.crt
    • Stop traversing nested certificate directories
    • Keep current aliasing, duplicate detection, and temporary truststore behavior intact
  • System truststore copy path

    • Revert system CA copy behavior to top-level certificate files only
    • Skip non-file matches safely instead of flattening nested paths into destination filenames
  • Generated image consistency

    • Update docker_templates/entrypoint.sh.j2
    • Regenerate all Linux entrypoint.sh files so template and checked-in outputs stay aligned
  • Test fixture rollback

    • Remove nested certificate fixtures used only to exercise sub-directory support
    • Update the CA certificate test script to stop asserting import of the nested dockerbuilder3 certificate
for i in /certificates/*.crt; do
    if [ ! -f "$i" ]; then
        continue
    fi
    # import top-level certs only
done

Copilot AI and others added 3 commits August 14, 2026 09:30
Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
Copilot AI changed the title [WIP] Revert the CA certs sub-dir support Revert CA cert sub-directory processing in Linux entrypoints Aug 14, 2026
Copilot AI requested a review from andrew-m-leonard August 14, 2026 09:34
Comment thread 11/jdk/ubi/ubi10-minimal/entrypoint.sh Outdated
Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
Comment thread 11/jdk/alpine/3.24/entrypoint.sh Outdated
Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
@andrew-m-leonard

Copy link
Copy Markdown
Contributor

@copilot I notice the original PR did 97 file changes, but your have reverted 109 files, can you explain the difference?

Copilot AI commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

@copilot I notice the original PR did 97 file changes, but your have reverted 109 files, can you explain the difference?

Because this PR is reverting the behavior against today’s generated tree, not replaying the exact inverse of #955 on the old tree.

The original #955 commit (58ad0cfb) changed 97 files. Compared with that, this branch has:

  • 12 additional generated entrypoints for Alpine 3.24 variants that did not exist in #955
  • 1 added test file change (test_generate_dockerfiles.py) to lock the restored *crt glob and cp -La /certificates/* ... behavior back in
  • 1 fewer file because #955 also happened to add 25/jre/ubuntu/resolute/InRelease, and this revert does not touch that unrelated file

So the net is 97 + 12 + 1 - 1 = 109.

…image

Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
Comment thread 25/jre/alpine/3.23/Dockerfile Outdated
Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>

@andrew-m-leonard andrew-m-leonard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have checked every file change

@andrew-m-leonard
andrew-m-leonard marked this pull request as ready for review August 14, 2026 11:39

@steelhead31 steelhead31 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gdams
gdams merged commit 666f8fc into main Aug 14, 2026
267 of 269 checks passed
@gdams
gdams deleted the copilot/revert-ca-certs-sub-dir-support branch August 14, 2026 13:00
dph5199278 pushed a commit to dph5199278/adoptium-containers that referenced this pull request Aug 21, 2026
…m#1032)

* Initial plan

* Revert CA cert sub-dir support

Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>

* Skip subdirectories when copying CA certs

Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>

* Limit CA cert processing to .crt files

Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>

* Restore original CA cert glob pattern

Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>

* Restore exact CA copy command

Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>

* Add wget retries for Temurin tarball downloads in 25 alpine 3.23 jre image

Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>

* Revert transient wget retry change in 25 alpine 3.23 jre Dockerfile

Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert the CA certs sub-dir support

4 participants