Repository navigation
Revert CA cert sub-directory processing in Linux entrypoints - #1032
Merged
Merged
Conversation
Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Revert the CA certs sub-dir support
Revert CA cert sub-directory processing in Linux entrypoints
Aug 14, 2026
Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
Contributor
|
@copilot I notice the original PR did 97 file changes, but your have reverted 109 files, can you explain the difference? |
Contributor
Author
Because this PR is reverting the behavior against today’s generated tree, not replaying the exact inverse of #955 on the old tree. The original
So the net is |
…image Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
andrew-m-leonard
approved these changes
Aug 14, 2026
andrew-m-leonard
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I have checked every file change
andrew-m-leonard
marked this pull request as ready for review
August 14, 2026 11:39
gdams
approved these changes
Aug 14, 2026
dph5199278
pushed a commit
to dph5199278/adoptium-containers
that referenced
this pull request
Aug 21, 2026
…m#1032) * Initial plan * Revert CA cert sub-dir support Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com> * Skip subdirectories when copying CA certs Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com> * Limit CA cert processing to .crt files Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com> * Restore original CA cert glob pattern Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com> * Restore exact CA copy command Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com> * Add wget retries for Temurin tarball downloads in 25 alpine 3.23 jre image Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com> * Revert transient wget retry change in 25 alpine 3.23 jre Dockerfile Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: andrew-m-leonard <31470007+andrew-m-leonard@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The July image publish is blocked downstream because the CA cert sub-directory support introduced in PR #955 expands the generated image diffs beyond what
docker-library/official-imageswill accept. This change manually reverts that behavior in the current entrypoints while preserving unrelated later certificate-handling fixes.Entrypoint behavior
/certificates/*.crtSystem truststore copy path
Generated image consistency
docker_templates/entrypoint.sh.j2entrypoint.shfiles so template and checked-in outputs stay alignedTest fixture rollback
dockerbuilder3certificate