Declare null hoveredItem signal for highlightedItem only lines - #969
Open
Hashim1999164 wants to merge 2 commits into
Open
Hashim1999164 wants to merge 2 commits into
Hashim1999164 wants to merge 2 commits into
Conversation
When highlightedItem makes a Line the interactive mark target but the line has no hover UI, encodings still reference line0_hoveredItem. Declare a null placeholder so Vega does not throw Unrecognized signal.
Author
|
added the missing changeset for the vega-spec-builder-s2 patch. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #958
When a chart sets
highlightedItemon a Line with no hover UI (no ChartTooltip, ChartPopover, onClick, etc.),getInteractiveMarkNamestill treats the line as the interactive mark target. Opacity rules and the hover animationhoveredMatchexpression then referenceline0_hoveredItem, butaddSignalsreturned early for non interactive lines so that signal was never declared. Vega threwUnrecognized signal name: "line0_hoveredItem".This declares a null
${name}_hoveredItemplaceholder in that case so the encodings resolve. There are still no mouse handlers because there is no hover UI to drive them. Controlled highlighting continues to work throughcontrolledHighlightedItem/ highlighted data.Test plan
yarn test:quiet packages/vega-spec-builder-s2/src/line/lineSpecBuilder.test.tsaddSignalsand via fulladdLine(animations on and off)