Feat/s2 animation ticker - #964
Open
c-lamoureux wants to merge 7 commits into
Open
c-lamoureux wants to merge 7 commits into
c-lamoureux wants to merge 7 commits into
Conversation
- Replace each chart's always-on Vega timer with a page-wide on-demand rAF ticker (animationTicker): idle charts do no work, off-screen charts pause, 8ms frame budget. - Specs emit an animationActive signal (hover and draw-in conditions) so the ticker knows when a chart can sleep; standalone Vega consumers keep the timer. - Draw-in clock starts on the first tick so the first painted frame is at 0% progress. - Add `yarn perf:animation` benchmark (drawIn/hover/idle scenarios, presets). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…udget clock comment Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…omments Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…a data source The data-backed condition only fed the timer filter, which the ticker strips, and benchmarked slightly slower. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Contributor
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-964 🎨 S2 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-964-s2 📚 Docs -> https://opensource.adobe.com/react-spectrum-charts/PR-964-docs/ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: