fix(ADBLABS-217): Abstract text alignment is off at some breakpoints - #128
Open
luisSilvaEs wants to merge 1 commit into
Open
luisSilvaEs wants to merge 1 commit into
luisSilvaEs wants to merge 1 commit into
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
.abstract__itemchildren on their text baseline instead of the box top edgeflex-shrink: 0to.abstract__numberso the number column no longer compresses at intermediate viewport widths--s2a-typography-line-height-title-6token with the correct--s2a-typography-line-height-heading-6, matching the font-size and letter-spacing tokens already used on the same ruleRelevant Links
Test URLs:
Checklist
Validation
Validation steps
abstractblocks (unordered list, no numbers) render unaffectedBrowser Testing
We should aim to support the latest version of the listed browsers. For older versions or other browsers not on the list, content should be accessible, even if it doesn't completely match the designs.
Developers should test as they work in the browsers available on their machines. If they have access to other devices to test other browser/OS combinations, they should do that when possible.
Blocks and pages should undergo comprehensive testing to ensure they work as expected in real-use scenarios. Standard testing during pre-production should include at least these browsers.
Dark mode and light mode
Most pages support both dark and light mode, based on
prefers-color-scheme.Changes that affect the frontend should support both color schemes.