Repository navigation
feat(DBLABS-158): Heroes keep the authored heading level - #118
Merged
Merged
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
amazingrando
marked this pull request as ready for review
October 1, 2026 13:48
amazingrando
changed the title
marissahuysentruyt
approved these changes
Oct 2, 2026
marissahuysentruyt
left a comment
marissahuysentruyt
left a comment
Collaborator
There was a problem hiding this comment.
All of the validation instructions check out! I had a very minor note on the README.
|
|
||
| In Document Authoring, insert a section break after the hero table. Paste the hero image as a normal picture — you do not need to set `loading` or `fetchpriority`. Adding `fetchpriority="high"` or a preload usually makes Lighthouse scores worse on Edge Delivery; see Adobe’s [keeping-it-100](https://www.aem.live/developer/keeping-it-100) guidance. | ||
|
|
||
| Set the headline's heading level in Document Authoring. The hero keeps that element: Heading 1, Heading 2, or the default paragraph. Articles that need a single page title use Heading 1. A page with more than one hero, such as Sneaks, should not use Heading 1 for each one. The same note belongs on the hero block in the library (`/docs/library/blocks/hero`). That page is Document Authoring content and publishes separately from this repo. |
Collaborator
There was a problem hiding this comment.
Do we need the last couple of sentences in this paragraph, about "The same note belongs on the hero block in the library..."?
to me, it sort of reads like an internal note, but I could be wrong.
Collaborator
Author
There was a problem hiding this comment.
Good edit. I've updated it.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
h1–h6, or a paragraph for default text) instead of always forcing anh2..hero__headlineso Heading 1, Heading 2, and a paragraph look the same./docs/library/blocks/hero) is Document Authoring content and still needs the same note published separately.Relevant Links
Test URLs:
Checklist
Validation
Validation steps
/): category stays in the eyebrow, the date stays at the top right, the headline is the article title, and Read stays at the bottom right. The headline element is apbecause that page authors a link with no heading style./research/how-creatives-are-thinking-about-ai): the headline is anh1.hero__headlinewith the article title, and it is the onlyh1on the page.h2.hero__headline.p.hero__headline.javascript:URL does not become a link.Browser Testing
We should aim to support the latest version of the listed browsers. For older versions or other browsers not on the list, content should be accessible, even if it doesn't completely match the designs.
Developers should test as they work in the browsers available on their machines. If they have access to other devices to test other browser/OS combinations, they should do that when possible.
Blocks and pages should undergo comprehensive testing to ensure they work as expected in real-use scenarios. Standard testing during pre-production should include at least these browsers.
Dark mode and light mode
Most pages support both dark and light mode, based on
prefers-color-scheme.Changes that affect the frontend should support both color schemes.