Repository navigation
Timer fully built - #17
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
One critical and two moderate unresolved issues remain.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a client-side recruitment countdown and deadline-aware homepage CTA.
Changes:
- Implements dot-matrix countdown rendering and accessibility labeling.
- Adds deadline-based recruitment state and closed-state messaging.
File summaries
| File | Summary and review findings |
|---|---|
src/components/Countdown.tsx |
Implements the countdown display. Moderate issues: accessible text omits seconds (3 votes), and durations beyond 99 days are not monotonic (1 vote). |
src/app/page.tsx |
Integrates deadline-based recruitment state. Critical issue: closure is client-only, allowing the prerendered or no-JavaScript page to expose the Google Forms link after the deadline (2 votes). |
Review details
Suppressed comments (1)
src/components/Countdown.tsx:80
- When the target is more than 99 days away, capping only the day field makes the displayed duration increase as the real countdown decreases: 100 days shows
99:00:00:00, then 99 days 23:59:59 shows99:23:59:59. Clamp the total seconds to the largest representable duration before splitting so the timer remains monotonic.
// Only two digits fit, so anything past 99 days shows as 99
{ label: "Days", value: Math.min(99, Math.floor(seconds / 86400)) },
{ label: "Hours", value: Math.floor(seconds / 3600) % 24 },
{ label: "Minutes", value: Math.floor(seconds / 60) % 60 },
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+83
to
+84
| const [deadlinePassed, setDeadlinePassed] = useState(false); | ||
| const applicationsOpen = isRecruiting && !deadlinePassed; |
Comment on lines
+123
to
+126
| const spoken = units | ||
| .slice(0, 3) | ||
| .map((unit) => `${unit.value} ${unit.label.toLowerCase()}`) | ||
| .join(", "); |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.