Fix map compositing edge case & loss of alpha channel data#28
Open
augenfrosch wants to merge 2 commits into
Open
Fix map compositing edge case & loss of alpha channel data#28augenfrosch wants to merge 2 commits into
augenfrosch wants to merge 2 commits into
Conversation
… of checking for `d` texture
… formats that can use it
ackwell
reviewed
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes minor issues with the map asset endpoint, where the maps
r2t2/00&d2a8/00were completely black by using a workaround & multiple small maps with transparent borders had black borders in the composited output by doing the compositing on theRgba8images and allowing output formats other than JPEG.Sanity checking the performance, since one additional channel has to be composited with the current changes, using the tool I'm working on that uses boilmaster's asset endpoint code that extracts all maps in the
Mapsheet to disk, I get the following result:I'm assuming the slight performance gain comes from the fact that the
into_rgba8()call is faster since theDynamicImages are all aDynamicImage::ImageRgba8variant and/or the existence check for thedtexture not being necessary with the workaround.