Repository navigation
Follow LICENSE.md for npm LicenseRef-LICENSE.md #2872 - #5383
Open
nikhilkumarpanigrahi wants to merge 1 commit into
Open
nikhilkumarpanigrahi wants to merge 1 commit into
nikhilkumarpanigrahi wants to merge 1 commit into
Conversation
Signed-off-by: nikhilkumarpanigrahi <nikhilkumarpanigrahi29@gmail.com>
Author
|
@AyanSinhaMahapatra this PR is ready for review. The |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2872
I checked the legacy npm
"license": "LicenseRef-LICENSE"convention on currentdevelop.It already works:
proprietary-license_720.RULE(added in 936b3a4) hasreferenced_filenames: LICENSE, so the license in the siblingLICENSEfile is followed.This works for the string, dict and list forms, and for
bower.json.The
LicenseRef-LICENSE.mdvariant did not work.LicenseRef-LICENSE.mdis listed inother_spdx_license_keysofproprietary-license, so it was matched by theauto-generated SPDX identifier rule. That rule has no
referenced_filenames, soLICENSE.mdwas never followed and the package was reported asproprietary-license.Changes
proprietary-license_1064.RULEforLicenseRef-LICENSE.mdwithreferenced_filenames: LICENSE.md, same asproprietary-license_720.RULE.tests/packagedcode/test_license_detection.pyfor bothLicenseRef-LICENSEandLicenseRef-LICENSE.mdin apackage.json, with an MITlicense in the sibling file.
Results
package.jsonlicenseLicenseRef-LICENSELICENSE(MIT)mitmitLicenseRef-LICENSE.mdLICENSE.md(MIT)proprietary-licensemitLicenseRef-LICENSEproprietary-licenseproprietary-licenseTasks