Repository navigation
Conversation
Signed-off-by: Gracy769 <169199616+Gracy769@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes missing
ignorable_urlsdeclarations insrc/licensedcode/data/rules/fsl-1.1_1.RULEandsrc/licensedcode/data/rules/fsl-1.1_2.RULE.Problem & Motivation
In recent
developbranch builds, Azure Pipelines CI has been failing on thelicense_validate_ignorables_2test suite (e.g. Build 19540 ondevelop):Commits
a49e06fand9eaa41dintroducedfsl-1.1_1.RULEandfsl-1.1_2.RULE, both of which contain the URLhttps://fsl.software/FSL-1.1-ALv2.template.md, but neither rule declaredignorable_urlsin their YAML frontmatter.During
check_ignorable_clues(),models.get_ignorables()detects the template URL from the text, whilemodels.get_normalized_ignorables()returns empty{}because the rule metadata was missing the declaration, causing the validation assert to fail.Changes
ignorable_urls: - https://fsl.software/FSL-1.1-ALv2.template.mdtosrc/licensedcode/data/rules/fsl-1.1_1.RULE.ignorable_urls: - https://fsl.software/FSL-1.1-ALv2.template.mdtosrc/licensedcode/data/rules/fsl-1.1_2.RULE.Testing
Verified in Python using
licensedcode.models:Both rules now match cleanly.