Repository navigation
Pin binaryornot to v0.4.4 to fix errors - #5357
Merged
Merged
Conversation
binaryornot 0.6.0 checks only the first 512 bytes of a file, and its UTF-8 check fails when that cut lands inside a multi-byte character, so UTF-8 text with CJK characters is classified as binary. Such files are then scanned as binary and only their ASCII strings are matched, which broke 4 data-driven license tests on develop since the bump (nysl-0.9982, nysl-0.9982_jp, MulanPSL-1.0.t1, fossology BSD manual-bsdstyle). This is an open upstream bug (binaryornot/binaryornot#658, #666, unmerged fix in #667). 0.4.4 is the version used before the bump; chardet, which it needs, is already pinned. Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
Also installs commoncode first and then scancode so that the requirements are honoured. Reference: #5343 Signed-off-by: Ayan Sinha Mahapatra <asmahapatra@aboutcode.org>
… fix-license-test-errors
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also installs commoncode first and then scancode so that the requirements are honoured.
Reference: #5343
Tasks
Run tests locally to check for errors.