Open
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/agent_execution/active_task.py | 96.48% | 96.29% | 🔴 -0.19% |
| Total | 93.01% | 93.01% | 🔴 -0.01% |
Generated by coverage-comment.yml
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the ActiveTask consumer logic by extracting it into a dedicated EventConsumer class, which improves maintainability and readability. The review feedback identifies several opportunities for improvement, including correcting type hints to include PushNotificationEvent, removing redundant conditional checks, optimizing the copying of Protobuf messages to avoid unnecessary overhead, and enhancing type safety by replacing Any with specific types in cast operations.
bartek-w
force-pushed
the
bartekw-event-consumer
branch
from
037d78a to
c875f85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve readability of ActiveTask._run_consumer(), by creating new EventConsumer class. Additionally EventConsumer methods have much easier to read types of Event on each stage of processing.
Fixes #1032 🦕