Skip to content

chore: Upgrading NullAway to 0.13.4 and error prone to 2.49.0 #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehsavoie merged 1 commit into from
Apr 30, 2026
+4 −5
Merged

chore: Upgrading NullAway to 0.13.4 and error prone to 2.49.0 #840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@
<slf4j.version>2.0.17</slf4j.version>
<logback.version>1.5.18</logback.version>
<version.testcontainers>1.21.4</version.testcontainers>
<error-prone.version>2.47.0</error-prone.version>
<nullaway.version>0.13.1</nullaway.version>
<error-prone.version>2.49.0</error-prone.version>
<nullaway.version>0.13.4</nullaway.version>
<error-prone.flag>-XDaddTypeAnnotationsToSymbol=true</error-prone.flag>
<nullaway.args>-Xplugin:ErrorProne -XepDisableAllChecks -Xep:NullAway:ERROR -Xep:RequireExplicitNullMarking:WARN -XepOpt:NullAway:ExhaustiveOverride=true -XepOpt:NullAway:OnlyNullMarked=true -XepOpt:NullAway:JSpecifyMode=true -XepExcludedPaths:.*/src/test/.* -XepDisableWarningsInGeneratedCode</nullaway.args>
Comment thread
ehsavoie marked this conversation as resolved.

Expand Down
3 changes: 1 addition & 2 deletions server-common/src/main/java/org/a2aproject/sdk/server/events/MainEventBusProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@
import org.a2aproject.sdk.server.tasks.TaskSerializationException;
import org.a2aproject.sdk.server.tasks.TaskStore;
import org.a2aproject.sdk.spec.A2AError;
import org.a2aproject.sdk.spec.A2AServerException;
import org.a2aproject.sdk.spec.Event;
import org.a2aproject.sdk.spec.InternalError;
import org.a2aproject.sdk.spec.Message;
import org.a2aproject.sdk.spec.Task;
import org.a2aproject.sdk.spec.StreamingEventKind;
import org.a2aproject.sdk.spec.TaskArtifactUpdateEvent;
Expand Down Expand Up @@ -134,6 +132,7 @@ public void setPushNotificationExecutor(java.util.concurrent.Executor executor)
this.pushNotificationExecutor = executor;
}

@SuppressWarnings("NullAway.Init")
Comment thread
ehsavoie marked this conversation as resolved.
@PostConstruct
void start() {
processorThread = new Thread(this, "MainEventBusProcessor");
Expand Down
2 changes: 1 addition & 1 deletion ...common/src/main/java/org/a2aproject/sdk/server/requesthandlers/DefaultRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@
import org.a2aproject.sdk.spec.TaskPushNotificationConfig;
import org.a2aproject.sdk.spec.TaskQueryParams;
import org.a2aproject.sdk.spec.TaskState;
import org.a2aproject.sdk.spec.TaskStatusUpdateEvent;
import org.a2aproject.sdk.spec.UnsupportedOperationError;
import org.jspecify.annotations.NonNull;
import org.jspecify.annotations.Nullable;
Expand Down Expand Up @@ -270,6 +269,7 @@ public DefaultRequestHandler(AgentExecutor agentExecutor, TaskStore taskStore,
this.requestContextBuilder = () -> new SimpleRequestContextBuilder(taskStore, false);
}

@SuppressWarnings("NullAway.Init")
Comment thread
ehsavoie marked this conversation as resolved.
@PostConstruct
void initConfig() {
agentCompletionTimeoutSeconds = Integer.parseInt(
Expand Down