Add wider floating-point regression coverage - #63
Draft
1sgtpepper wants to merge 22 commits into
Draft
Conversation
1sgtpepper
marked this pull request as ready for review
July 29, 2026 12:22
1sgtpepper
marked this pull request as draft
August 10, 2026 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add behavior regressions for the wide
fp.divand sharedroundpaths inZ3Prover/z3#10216.
The 24 independent wide cases keep one floating-point operand symbolic and constrain it
only with
fp.eq, so the default QF_FP simplification path cannot foldfp.divbeforefpa2bv. They cover exact normalization, directed underflow, ties, overflow endpoints,ebits > sbits, andsbits == 2, with one expected result per case for precise failurelocalization. Other regressions cover all rounding modes, special values, and the shared
rounder's wide shift-count paths. A dedicated FP(2,16) quotient fails if the shift cap
18 is represented as the wrapped four-bit value 2.
Source change: Z3Prover/z3#10216. This PR must merge after that source change and
remains draft until it lands.
Testing
f42bacbf1combines source head51b80b21awiththis test head
9593fb035: build/test(14/14 jobs) and OCaml bindings
(2/2 jobs), both successful.
changes only the shift-cap width and fails the dedicated FP(2,16) regression.
uses the unpatched PR base with this test head; all 24 isolated wide cases fail in
each of its eight regression configurations. The cap-width control above isolates
the exact cap regression at the same test head.
workflows.