Skip to content

feat/v26.3 - #473

Closed
illyrius666 wants to merge 7 commits into
mainfrom
feat/v26.3
Closed

illyrius666 wants to merge 7 commits into
mainfrom
feat/v26.3

Conversation

@illyrius666

@illyrius666 illyrius666 commented Jul 8, 2026

Copy link
Copy Markdown
Member

Description

  • updated to mc 26.3
  • removes sitmechanic as that has been replaced by the vanilla cussion.
  • close mc 26.3 #476

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual testing
  • Other (please describe)

Summary by CodeRabbit

  • Removed Features
    • Removed the player sitting mechanic.
    • Players can no longer sit on blocks or use related sitting interactions.

@illyrius666 illyrius666 self-assigned this Jul 8, 2026
@github-actions github-actions Bot changed the title removed sitmechanic due to cussions being added in vanilla making this feat/v26.3 Jul 8, 2026
@illyrius666
illyrius666 deployed to 473/merge July 8, 2026 08:43 — with GitHub Actions Active
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Build completed for commit d01eb93.

View Artifacts
View Workflow Run

# Conflicts:
#	src/mechanics/player/SitMechanic.kt
@illyrius666

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ffe96d5e-fceb-4d2a-9f58-bda6aedcfd24

📥 Commits

Reviewing files that changed from the base of the PR and between f563ab6 and 874c502.

📒 Files selected for processing (2)
  • src/IllyriaPlus.kt
  • src/mechanics/player/SitMechanic.kt
💤 Files with no reviewable changes (2)
  • src/mechanics/player/SitMechanic.kt
  • src/IllyriaPlus.kt

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The player sitting mechanic was deleted. Plugin startup no longer registers SitMechanic. All other mechanic registrations remain unchanged.

Changes

Sit mechanic removal

Layer / File(s) Summary
Remove sitting behavior
src/mechanics/player/SitMechanic.kt, src/IllyriaPlus.kt
The SitMechanic implementation and its event handlers, seat management, tracking, and cleanup logic were removed. Startup no longer registers the mechanic.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to eca9f

The change removes the obsolete sitting mechanic and its startup registration, with no concrete unresolved merge risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The pull request removes SitMechanic, which supports the Minecraft 26.3 update, but the provided changes do not show an update to the project’s Minecraft version or dependency configuration required b… Add the required Minecraft 26.3 version and dependency updates, or provide evidence that those updates exist in the pull request. Verify that the project builds against Minecraft 26.3.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the Minecraft 26.3 update, which is the primary objective of the pull request.
Description check ✅ Passed The description includes the change summary, linked issue reference, and manual testing status. It is complete enough for review.
Out of Scope Changes check ✅ Passed The removal of SitMechanic is related to the Minecraft 26.3 update because vanilla cushions replace its functionality. No unrelated changes are shown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

The pull request removes SitMechanic, which supports the Minecraft 26.3 update, but the provided changes do not show an update to the project’s Minecraft version or dependency configuration required by issue #476.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/v26.3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

I am a rabbit with ears held high
The sitting mechanic hopped goodbye
No more armor stands in the square
No more seats waiting there
The plugin starts with a simpler stride

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 59 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mc 26.3

1 participant