Skip to content

Photo Directory: check the value that gets stored, not the one submitted #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
obenland wants to merge 2 commits into from
+11 −3
Closed

Photo Directory: check the value that gets stored, not the one submitted #877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaa9ea4
Photo Directory: Check the value that gets stored, not the one submitted
obenland Sep 4, 2026
51be978
Photo Directory: Refuse a submission the shortcode check cannot decide
obenland Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions wordpress.org/public_html/wp-content/plugins/photo-directory/inc/uploads.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,16 +703,24 @@ protected static function validate_upload_form() {
return 'checkbox_unchecked_license';
}

foreach ( [ 'post_title', 'post_content', 'post_excerpt' ] as $field ) {
// phpcs:ignore WordPress.Security.NonceVerification.Missing, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- Read raw: sanitizing before the check would hide what it looks for.
// The same fields and sanitizers `sanitize_submitted_description()` stores them with.
$fields = [
'post_title' => 'sanitize_text_field',
'post_content' => 'sanitize_textarea_field',
'post_excerpt' => 'sanitize_text_field',
];

foreach ( $fields as $field => $sanitize ) {
// phpcs:ignore WordPress.Security.NonceVerification.Missing, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized -- Sanitized on the next line, by whichever callback stores the field.
$submitted = isset( $_POST[ $field ] ) ? wp_unslash( $_POST[ $field ] ) : '';

// A field can arrive as an array, which Frontend Uploader drops before it builds the post.
if ( ! is_string( $submitted ) || '' === $submitted ) {
continue;
}

if ( preg_match( '/' . get_shortcode_regex() . '/', $submitted ) ) {
// Anything but a clean no-match is refused: preg_match() returns false when PCRE gives up.
if ( 0 !== preg_match( '/' . get_shortcode_regex() . '/', $sanitize( $submitted ) ) ) {
return 'shortcode-in-text';
}
}
Expand Down