Skip to content

WordPress.tv: Fix subtitle upload error on cached/unauthenticated submissions #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wprashed wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

WordPress.tv: Fix subtitle upload error on cached/unauthenticated submissions #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2e8515
WordPress.tv: Prevent stale nonce failure on subtitle uploads
wprashed Aug 19, 2026
362dc83
Sanitize and unslash nonce input
wprashed Aug 19, 2026
6bc44a4
Merge branch 'trunk' into meta-8406
wprashed Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...ontent/themes/wptv2/plugins/wordpresstv-upload-subtitles/wordpresstv-upload-subtitles.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,13 @@ function generate_filename( $file ) {
* When the POST request is fired with the subtitles form and action.
*/
function post() {
if ( empty( $_POST['wptv-upload-subtitles-nonce'] ) || ! wp_verify_nonce( $_POST['wptv-upload-subtitles-nonce'], 'wptv-upload-subtitles' ) ) {
if (
empty( $_POST['wptv-upload-subtitles-nonce'] ) ||
(
empty( $_POST['wptv_wporg_username'] ) &&
! wp_verify_nonce( sanitize_text_field( wp_unslash( $_POST['wptv-upload-subtitles-nonce'] ) ), 'wptv-upload-subtitles' )
)
) {
wp_die( 'Invalid form data. Please go back and try again.' );
}

Expand Down
2 changes: 2 additions & 0 deletions wordpress.tv/public_html/wp-content/themes/wptv2/upload-subtitles-template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ function subtitles_upload_css() {
wp_die( 'You can not subtitle this video, sorry.' );
}

nocache_headers();

get_header();

$message = '';
Expand Down