Tray: Replace the notch with a controls strip on the dock's edge - #701
Open
mmtr wants to merge 3 commits into
Open
Tray: Replace the notch with a controls strip on the dock's edge#701mmtr wants to merge 3 commits into
mmtr wants to merge 3 commits into
Conversation
Retires the notch and adds the tray, a pill of shell chrome carrying the site assistant's front door and Exit OpenStation. The assistant had no visible way in. Core's command-palette button is hijacked to open it, but the admin bar that button lives in is hidden by default, so the only entry point was the keyboard. The tray gives it one, with the chord spelled out next to it. Exit OpenStation moves off the dock. The dock is a list of things you open and close, and the one control that does neither kept being drawn as an exception to every rule the rail had: its own gap, a ring instead of a plate, a hover that leaned the other way. Its tile factory and that CSS go with it. SystemDockItem.locked stays as a public flag for plugins, though nothing built-in sets it now. The tray rests on the bottom dock as a second shelf, and falls back to floating in the top-right corner when the user puts their rail on a side edge. It reserves no work area in either placement. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…p-right-1356d1 # Conflicts: # assets/css/dock.css # assets/css/notch.css # docs/javascript-reference.md # src/desktop.ts
Reshapes the tray from a floating top-right pill into a strip that wraps the bottom dock, and gives side-placed rails the same two controls as tiles instead. The pill read as a second piece of chrome on a desktop whose point is not having any. As the dock's own edge, thickened until the controls fit inside it, it belongs to something already on screen. It claims the band it covers the way the dock does, by being measured. There is no tray without a bottom dock. Put the rail on a side edge and it detaches; the assistant leads the rail and Exit OpenStation closes it, which is where the exit was before the tray existed. Both hang off one predicate, `findBottomDock()`, so the two surfaces cannot both claim the job. `SystemDockItem.navKind` gains `'core'`, the only kind that sorts ahead of Dashboard. Additive: existing values are unaffected. Two bugs found on the way. `desktop-layout.ts` folded every non-control kind into `'app'`, and `'app'` defaults to the desktop, so a tile declaring any other kind was routed off the rail it asked for and never painted with nothing reporting a problem. And the tray read its surface from the dock's token family but its text from the palette's, which Legacy sets dark for light surfaces, so the strip rendered near-black text on dark glass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
⌘K/Ctrl+Kchord.SystemDockItem.navKindgains'core', the only kind that sorts ahead of Dashboard. Additive, so existing values are unaffected.Why are these changes being made?
The assistant had no visible entry point at all, and the notch it lived on was a second piece of floating chrome on a desktop whose whole point is not having any. Drawn as the dock's own edge, thickened until the controls fit inside it, it belongs to something already on screen.
Exit OpenStation was the other half. On the rail it had to be drawn as an exception to every rule the dock had (its own gap, a ring instead of a plate, a hover that leaned the other way) because the dock is a list of things you open and close and the exit does neither.
Testing Instructions
⌘Kbeside it and an exit glyph at the trailing end.⌘K(Ctrl+Kon Windows/Linux) and make sure it opens the same surface.