Repository navigation
Five for the Future: Let contributors join a pledge through a private link - #416
Merged
Merged
Conversation
… link Pledge admins get a join link on the manage page to share with their contributors. Opening it while logged in adds a pending invitation that the contributor confirms on My Pledges, like any other. Logging in from the link keeps it intact, and admins can reset the link if it reaches the wrong people. Fixes #350. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Don't let removed, declined, or departed contributors rejoin through the link; only the pledge admin can add them back. - Reset the link from its own form, so unsaved pledge edits aren't carried along, and log resets. - Create the key without overwriting a concurrent one, and build the link from the My Pledges permalink. - Look up contributors by login, which is what callers pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
obenland
force-pushed
the
add/pledge-join-link
branch
from
October 2, 2026 20:27
d49edab to
1733b32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #350.
Only the pledge admin can add contributors today, which becomes a bottleneck for larger companies. This adds a private join link that admins can share with their contributors.
How it works
To address the spam concern raised in the issue: a link alone never confirms anyone. The contributor still has to accept, the admin can remove people from the Unconfirmed list, and the link can be reset.
Details
5ftf_join-key). It's created the first time the link is shown and compared withhash_equals(). It only works for its own published pledge.my-pledge-listblock.Testing
npm run test:php -- --group contributor: the new test covers link stability, a wrong key, a key used on another pledge, a reset, and a deactivated pledge. A second test covers inviting once and a removed contributor not being able to rejoin.🤖 Generated with Claude Code