Skip to content

Fix launcher option replacement guard #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangminghuang merged 1 commit into from
Jun 12, 2026
Merged

Fix launcher option replacement guard #400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/TestHarness/launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@

block_dir = 'blocks'

def _is_command_option(token):
"""Return whether a command-line token is an option name rather than an option value."""
return token.startswith('--')

class EnhancedEncoder(json.JSONEncoder):
def default(self, o):
if is_dataclass(o):
Expand Down Expand Up @@ -575,7 +579,7 @@ def construct_command_line(self, instance: nodeDefinition):
if '-' in arg and arg not in repeatable:
if arg in sysdcmd:
i = sysdcmd.index(arg)
if sysdcmd[i+1] != '-':
if i + 1 < len(sysdcmd) and not _is_command_option(sysdcmd[i+1]):
sysdcmd.pop(i+1)
sysdcmd.pop(i)
sysdcmd.extend(specificList)
Expand Down