Skip to content

Fix Clang unroll warning in LEB128 helpers #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangminghuang merged 3 commits into from
Jun 18, 2026
Merged

Fix Clang unroll warning in LEB128 helpers #13

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b38b5a7
Fix clang unroll warning in LEB128 helpers
huangminghuang Jun 18, 2026
f5c6420
Use #pragma clang loop unroll_count(5) instead of dropping the hint
huangminghuang Jun 18, 2026
69b9bc6
Use #ifdef __clang__ for style consistency with the rest of the file
huangminghuang Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions include/sysio/vm/leb128.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace sysio { namespace vm {
bytes_used = 0;

#ifdef __clang__
#pragma unroll
#pragma clang loop unroll_count(5)
#elif defined(__GNUC__)
#pragma GCC unroll 5
#endif
Expand Down Expand Up @@ -84,7 +84,7 @@ namespace sysio { namespace vm {
uint32_t ret = 0;

#ifdef __clang__
#pragma unroll
#pragma clang loop unroll_count(5)
#elif defined(__GNUC__)
#pragma GCC unroll 5
#endif
Expand Down Expand Up @@ -181,7 +181,7 @@ namespace sysio { namespace vm {
bytes_used = 0;

#ifdef __clang__
#pragma unroll
#pragma clang loop unroll_count(5)
#elif defined(__GNUC__)
#pragma GCC unroll 5
#endif
Expand All @@ -200,7 +200,7 @@ namespace sysio { namespace vm {
typename std::make_unsigned<T>::type ret = 0;

#ifdef __clang__
#pragma unroll
#pragma clang loop unroll_count(5)
#elif defined(__GNUC__)
#pragma GCC unroll 5
#endif
Expand Down
Loading