Support renamed SoftFloat types - #11
Merged
Merged
Conversation
heifner
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
softfloat32_tandsoftfloat64_ttype names.softfloat@3.0.0#1.1.1.1to match the registry port version consuming this change.What changed
include/sysio/vm/softfloat.hppand the x86_64 softfloat glue.referencepin alongside the baseline so standalone eos-vm builds resolve the fixed SoftFloat port.Why
softfloat@3.0.0#1exportsSOFTFLOAT_DISABLE_LEGACY_TYPE_ALIASES, so consumers can no longer rely onfloat32_tandfloat64_t. This lets sys-vm build against the fixed SoftFloat package used by the macOS arm64 Wire Sysio dependency update.Testing
cmake -B build/softfloat-rename -S . -G Ninja -DCMAKE_BUILD_TYPE=Debug -DENABLE_TESTS=OFF -DENABLE_SOFTFLOAT_INSTALL=OFF -DCMAKE_INSTALL_PREFIX=/tmp/eos-vm-softfloat-rename-install -DCMAKE_TOOLCHAIN_FILE=$PWD/../wire-sysio/vcpkg/scripts/buildsystems/vcpkg.cmakecmake --build build/softfloat-rename --target install -- -j6