Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Targets Velocity 3.5.1 as the runtime platform, built on Java 21. This reverts the runtime requirement introduced in
794a875("require Velocity 4.1 build 8") so the plugin loads on Velocity 3.5.1.Changes
gradle.propertiesonly:velocity_api_version:4.1.0→3.5.1velocity_snapshot:true→false(3.5.1 is a release, not a snapshot; fixes the dev-run server download)velocity_minimum_build:8→615(3.5.1's build per PaperMC's fill API)velocity_compile_api_versionkept at3.5.0—velocity-proxy:3.5.1is not published as a release (only SNAPSHOTs exist), and the3.5.0-SNAPSHOTproxy is API-compatible with what runs on 3.5.1, so no source changes are needed.javaVersionunchanged (already21).Test plan
./gradlew clean shadowJarsucceeds onopenjdk 21.0.11(printsUsing Velocity API version: 3.5.1)metadata.ymlin the jar readsvelocity_api_version: '3.5.1',velocity_minimum_build: 615