Open
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
observablebenchmark — Proxy + class inheritance reactivityWhat this adds
This PR adds a new workload benchmarking
observable, a reactive state library that implements observability viaProxycombined with class inheritance, without redefining any object properties.Why it complements the existing
mobxworkloadJetStream already includes a MobX benchmark, which makes this a natural addition — but
observableexercises a meaningfully different engine codepath for achieving the same goal (reactive state tracking).The two approaches differ at a fundamental level:
Proxyfor some casesProxy+ class inheritance, no property redefinitionProxyusage[[Get]]/[[Set]]trapsThis distinction matters for engine benchmarking. JS engines optimize property access on objects with stable hidden classes/shapes. MobX's getter/setter approach mutates those shapes, while
observableleaves the underlying object intact and routes all access through aProxywrapping an inherited prototype chain. These two patterns stress different parts of the runtime — property descriptor lookup vs. Proxy trap dispatch — making them complementary workloads rather than redundant ones.Why this is a realistic workload
Proxy-based reactivity with class inheritance is a growing pattern in the JS ecosystem. Libraries that avoid property mutation are increasingly preferred for their compatibility with class fields, decorators, and stricter object models. Benchmarking this pattern gives engine developers and implementors signal on how well
Proxy+ prototype-chain access performs under sustained reactive workloads, which MobX alone does not cover.Summary
The existing
mobxbenchmark tests reactivity through property descriptor manipulation. This PR adds a workload that tests reactivity throughProxyinterception on top of class inheritance — a distinct, real-world pattern that deserves its own benchmark slot in JetStream.