perf: use unordered_set for Name sets for better compile speed#8586
Open
Changqing-JING wants to merge 2 commits intoWebAssembly:mainfrom
Open
perf: use unordered_set for Name sets for better compile speed#8586Changqing-JING wants to merge 2 commits intoWebAssembly:mainfrom
Changqing-JING wants to merge 2 commits intoWebAssembly:mainfrom
Conversation
Changqing-JING
force-pushed
the
opt/compile-speed
branch
from
cd4d3c2 to
7b0e889
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasm::Namehas an O(1) pointer-based hash butoperator<does O(n)memcmp, makingstd::set<Name>unnecessarily slow. On large workloads, ~35% ofwasm-optCPU time was spent in__memcmp_evex_movbeinsideEffectAnalyzer::walkcalled fromCodeFolding. Switching the fourstd::set<Name>fields inEffectAnalyzer,NameSetin branch-utils.h, and the local containers inCodeFoldingto their unordered equivalents eliminates the bottleneck.