[Stack Switching] wasm-ctor-eval: stop on serializing continuations to globals#8585
Merged
kripken merged 1 commit intoWebAssembly:mainfrom Apr 9, 2026
Merged
Conversation
stevenfontanella
approved these changes
Apr 8, 2026
Comment on lines
+416
to
+425
| ;; CHECK: (func $read (type $2) (result (ref null $cont)) | ||
| ;; CHECK-NEXT: (global.get $global) | ||
| ;; CHECK-NEXT: ) | ||
| ;; NOKEEP: (func $read (type $2) (result (ref null $cont)) | ||
| ;; NOKEEP-NEXT: (global.get $global) | ||
| ;; NOKEEP-NEXT: ) | ||
| (func $read (export "read") (result (ref null $cont)) | ||
| (global.get $global) | ||
| ) | ||
| ) |
Member
There was a problem hiding this comment.
nit: I guess this isn't needed?
Member
Author
There was a problem hiding this comment.
The above testcases use this pattern, because without it, the global is only written to and never read, so it can be trivially optimized out. I suspect this case might not need it as it can't optimize, but I think it's better to follow the shape of the above testcases so the diff compared to them is small and clear.
(Note that even if we don't need this now, we might need it later - ctor-eval runs a few opt passes after its work, and while simplify-globals, the pass that would remove the write-only global, is not yet run, we might add it later. Similar passes are already there.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuations cannot be serialized.