Skip to content

# Resolved Bug : Design system > Complete chart stories prop migration for data/options - #3872

Merged
Sagar-Bagwe merged 6 commits into
user/sagar/task-design-system-audit-fixes-phase-2from
user/shivani/Bug-Chart-stories-prop-migration
Oct 26, 2026
Merged

Sagar-Bagwe merged 6 commits into
user/sagar/task-design-system-audit-fixes-phase-2from
user/shivani/Bug-Chart-stories-prop-migration

Conversation

@Shivani-Dhobale777

@Shivani-Dhobale777 Shivani-Dhobale777 commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Resolve the issues on:

  • Updated chart Storybook stories to use the new data prop structure instead of legacy labels and dataSets props.
  • Configured Storybook controls for data and options to support editing chart data and configurations.
  • Hid deprecated props from Storybook documentation to keep the documented API consistent.
  • Updated chart stories to align with the current component API while preserving existing datasets, labels, styling, and chart configurations.
  • Updated affected chart stories and Figma Code Connect examples where applicable.
  • Improved consistency across chart documentation and examples.

Screenshots

Not applicable — chart prop migration and Storybook documentation updates.

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

- Updated chart stories to use the new data prop structure.
- Enabled editable data and options controls in Storybook.
- Hid deprecated props from Storybook documentation.
- Preserved existing chart datasets and configurations.
…dit-fixes-phase-2' into user/shivani/Bug-Chart-stories-prop-migration
@codesandbox

codesandbox Bot commented Oct 26, 2026

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1f0f4afc-7b23-4814-9353-f94475e4da6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Shivani-Dhobale777 Shivani-Dhobale777 self-assigned this Oct 26, 2026
@Shivani-Dhobale777 Shivani-Dhobale777 added the Bug Something isn't working label Oct 26, 2026
Sagar-Bagwe and others added 4 commits October 26, 2026 14:51
… user/shivani/Bug-Chart-stories-prop-migration
… user/shivani/Bug-Chart-stories-prop-migration
Validate icon names before accessing ChartIcons.
Improve SVG icon rendering and preserve existing chart functionality.

@Sagar-Bagwe Sagar-Bagwe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@Sagar-Bagwe
Sagar-Bagwe merged commit 72bb36a into user/sagar/task-design-system-audit-fixes-phase-2 Oct 26, 2026
1 check passed
@Shivani-Dhobale777 Shivani-Dhobale777 changed the title User/shivani/bug chart stories prop migration # Resolved Bug : Design system > Complete chart stories prop migration for data/options Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants