Repository navigation
# Fixed Bug: Chart Prop Migration Across Raaghu Design System - #3871
Closed
Shivani-Dhobale777 wants to merge 46 commits into
Closed
Shivani-Dhobale777 wants to merge 46 commits into
Shivani-Dhobale777 wants to merge 46 commits into
Conversation
…improve chart component structure - Changed main and module entry points in package.json to use CommonJS and ES module formats. - Enhanced Vite configuration to handle external dependencies more effectively. - Refactored chart utility functions and components to streamline code and improve maintainability. - Updated adaptive card components to simplify state management and improve prop handling. - Added tests to ensure proper functionality and address deprecation warnings in chart components.
…troduced `createCenterTextPlugin` for rendering centered titles and subtitles in doughnut and gauge charts. - Updated chart components to utilize the new plugin for enhanced visual representation. - Refactored chart utility functions for better maintainability and clarity. - Added deprecation warnings for outdated props in various components to guide users towards updated usage.
…eprecation warnings and new features - Updated `useChart` to return a structured result with canvas and chart references. - Enhanced `RdsCompAiAttachment` to support file selection and Figma URL changes, while adding deprecation warnings for outdated props. - Improved `RdsCompAiChatBot` and `RdsCompAiTypingSection` to handle new props and maintain backward compatibility. - Added tests for new functionalities and ensured proper handling of deprecated features.
…d utility functions - Added `kanban-board-helpers.ts` to manage Kanban board state, including actions for adding and editing boards and subcards. - Implemented utility functions for date formatting and random ID generation. - Defined interfaces for Kanban board and subcard structures to enhance type safety and clarity.
…d controlled state management - Introduced `ToolbarOption` interface for dropdown items. - Updated `RdsCompToolbar` to support custom button items and controlled active formats. - Improved dropdown handling with keyboard accessibility and layout effects. - Added tests to validate new features and ensure proper functionality.
…leted `setup.ts` which contained mock implementations for `matchMedia`, `ResizeObserver`, `IntersectionObserver`, and `scrollIntoView`. This cleanup helps streamline the test setup process.
- Updated RdsButton component to enhance code readability and maintainability. - Refactored RdsCheckbox to remove deprecated props and improve prop handling. - Enhanced RdsCounter with clearer prop management and added mandatory prop. - Modified RdsFileUploader components to replace isMandatory with mandatory for clarity. - Updated RdsFormControl to replace isGroup with group and improved prop handling. - Adjusted storybook stories to reflect prop name changes and improve documentation.
…themes-utils-builds-issues Completed task : Fix design-system audit issues.
…ts - Renamed `title` and `subText` props to `name` and `description` in `RdsAvatar` and related components for consistency. - Updated tests and stories to reflect these changes, ensuring backward compatibility and improved clarity in prop usage.
…ling and styling consistency; update deprecated props and adjust storybook examples for RdsTextField and RdsCompLayout to reflect new prop names.
…Uploader and RdsCheckbox - Renamed `onFilesChange` to `onChange` in `RdsFileUploader` for consistency. - Updated `RdsCheckbox` to introduce `variant` prop, replacing `style` for shape specification, and added tests for new prop behavior. - Improved test coverage for `RdsCollapse` and `RdsDialog` components with deprecation warnings for outdated props.
…y in RdsHeader and RdsInput - Renamed `tabValue` and `onTabChange` to `tabsValue` and `onTabsChange` in `RdsHeader` for consistency and clarity. - Updated `RdsInput` to replace `titlePosition` with `labelPlacement`, and introduced `startIcon` and `endIcon` props for better icon handling. - Added deprecation warnings for outdated props to guide users towards updated usage.
…onality in RdsPagination - Renamed `onPageChange` to `onChange` and `showDropdown` to `showPageSize` for clarity and consistency. - Introduced deprecation warnings for outdated props to guide users towards updated usage. - Updated tests to reflect these changes and ensure backward compatibility.
…andling - Replaced `active` prop with `selected` in sidebar items for clarity and consistency. - Updated user avatar handling to utilize `user.avatarSrc` instead of `avatarSrc`, with deprecation warnings for the outdated prop. - Enhanced tests to validate new behavior and ensure backward compatibility.
…y in RdsCompAiAttachment and RdsCompAiChatBot - Renamed props in RdsCompAiAttachment for clarity, introducing `icon`, `badge`, and `slotProps` while deprecating outdated props. - Updated RdsCompAiChatBot to use `assistantAvatar` and `userAvatar`, replacing `aiLogoUrl` and `userAvatarUrl` with deprecation warnings. - Enhanced tests to validate new prop usage and ensure backward compatibility.
…tionality in RdsCompColorPicker - Renamed `pickerType` to `view` and `colorMode` to `format` for clarity and consistency. - Introduced new props `variant`, `defaultView`, and `defaultFormat`, while deprecating outdated props with warnings. - Updated tests and stories to reflect these changes and ensure backward compatibility.
…s for clarity and consistency - Renamed `filters` to `options` in `RdsCompFilterButton` and updated related components to reflect this change, introducing deprecation warnings for the outdated prop. - Enhanced `RdsCompKanbanBoard` to utilize `columns` and `defaultColumns` instead of `boardData`, with corresponding deprecation warnings. - Updated tests and stories to validate new prop usage and ensure backward compatibility.
…y across multiple components - Updated `RdsCompProductTour`, `RdsCompSpinner`, `RdsCompTextEditor`, `RdsCompTimePicker`, and `RdsCompToast` to introduce new props and deprecate outdated ones, ensuring clarity and consistency. - Added tests to validate new prop usage and ensure backward compatibility, including handling of deprecated props with warnings. - Enhanced accessibility and functionality in various components.
- Updated RdsCompGrid, RdsCompNavtabs, RdsCounter, RdsFileUploader, and RdsTextArea components to replace deprecated prop names (e.g., isSort, isFilter, isResizable, mandatory) with more intuitive names (e.g., Sort, Filter, Resizable, required). - Adjusted related logic and state management to reflect the new prop names. - Improved code readability by formatting and organizing code blocks. - Ensured backward compatibility by removing deprecated props and updating documentation accordingly.
…-prop-rename-table-issues Completed Task : Design System > Audit Fixes, API Standardization, and React 19/MUI 7 Compatibility
…ate old props and improve code clarity
…' prop instead of 'style' for better clarity and consistency; adjust related Figma files and stories accordingly refactor: modify RdsTextArea to replace 'style' with 'variant' for visual representation; update stories and documentation refactor: change RdsTooltip to utilize 'variant' for placement instead of deprecated 'style'; update stories to reflect this change refactor: adjust RdsCompAppShell to use 'variant' prop for styling; ensure consistency across component usage in stories fix: update DashboardPage to use 'progressVariant' in LinearProgress components for correct prop usage
…ponent; enhance clarity and consistency in type definitions and styling functions
…ructure - Improved prop filtering logic in Storybook configuration to exclude deprecated props. - Updated various chart components to standardize data structure, replacing `dataSets` with `data` and ensuring consistency across multiple chart types. - Enhanced stories for better clarity and usability.
… user/shivani/bug-prop-inventory
…ecated prop handling - Updated button components across various files to replace `style` with `variant` for improved clarity and consistency. - Introduced deprecation warnings for outdated props, ensuring backward compatibility. - Adjusted related tests and stories to reflect these changes.
…inventory Fixed Bug: Prop Naming Consistency Across Raaghu Design System
…Updated `RdsCompToolbarProps` to clarify the behavior of `disabled-on` and `disabled-off` states. - Improved SCSS styles for disabled states to ensure consistent visual feedback. - Adjusted stories to better demonstrate the new state handling and added default values for clarity.
…ents - Removed state prop from RdsTabs and updated related styles and tests. - Simplified RdsTextArea by eliminating state handling and replacing it with error and selected props. - Updated styles in RdsTextArea to reflect changes in state management. - Adjusted Storybook stories and tests for both components to align with the new prop structure. - Cleaned up unused state-related code and enums in both components.
- Updated `NodeState` and `IconType` in `rds-comp-tree-structure` to use const objects. - Removed `NodeState` from exports and adjusted related tests and components. - Refactored `TruncateTextState` to a const object in `rds-comp-truncate-text` and updated all references. - Removed deprecated `state` prop from `RdsCompTruncateText` and adjusted tests accordingly. - Updated `TextareaStyle` in `rds-text-area` to a string union type and removed enum usage. - Refactored `AppShellDisplayType` to a const object for better type inference. - Adjusted imports and exports across components to reflect the changes in type definitions. - Cleaned up test files to remove references to deprecated props and ensure consistency with new implementations.
… and improve type safety - Updated `RdsCompAiAttachment`, `RdsCompAiChatBot`, and `RdsCompAiFabMenu` to use `RdsCompAiFabMenuIcon` type for icon props. - Changed `iconName` prop in `RdsCompAiChatBot` and `RdsCompAiTypingSection` to accept `ReactNode`. - Modified `RdsCompAiFabMenu` to handle custom icon elements and updated tests accordingly. - Refined `ChartIcons` to use a constant type and updated related components to ensure type safety. - Enhanced `RdsDivider` to utilize `RdsDividerIconName` for icon selection and improved icon rendering logic. - Adjusted `RdsCompDetailsPane` and `RdsCompEmptyState` to allow for custom icon nodes. - Updated `RdsCompKanbanBoard` to use specific types for tag and category options. - General cleanup and deprecation warnings added for better maintainability.
- Added className, sx, and ref props to RdsButtonDropdown, RdsCounter, RdsFileUploader, RdsLoader, RdsMultiLevelMenu, RdsProgress, RdsTextArea, and RdsCompAppShell components for improved styling and accessibility. - Updated respective stories and tests to reflect the new props and ensure proper functionality. - Ensured that native attributes are forwarded correctly to the root elements of the components.
…omp components - Added `ProductTourAnchorCorner` to `RdsCompProductTourProps` for improved functionality. - Simplified deprecated prop warnings in `RdsCompAiIcon` for better clarity. - Refactored tests in `RdsCompAudioPlayer`, `RdsCompColorPicker`, and `RdsCompDatepicker` to utilize setup functions for cleaner code and improved readability.
…ents - Renamed `ShowLeftIcon` to `showLeftIcon` and `changeleftIcon` to `changeLeftIcon` in RdsAccordion for better camelCase consistency. - Updated `labeltext` to `labelText` in RdsCheckbox, RdsButtonDropdown, and RdsDialog to align with naming conventions. - Adjusted tests and stories to reflect the new prop names. - Deprecated old prop names and added warnings for usage in RdsCheckbox and RdsDialog. - Introduced `labelPosition` prop in RdsSelect to replace deprecated `labelposition` for improved clarity.
… user/shivani/bug28-Prop-Inventory
… - Removed the `block` prop from `RdsCompAdaptiveCards`. - Updated `RdsCompAiFabMenuIcon` type to include string type for better flexibility. - Cleaned up SCSS files in `RdsCompCommentsBox` by removing commented-out code. - Removed unnecessary comments and deprecated code in `RdsCompDatePicker`. - Streamlined imports in `RdsCompDetailsPane` and `RdsCompGrid` by eliminating unused components. - Enhanced `RdsCompTreeStructure` by removing redundant comments and unused imports. - Updated `RdsCompTruncateText` logic for clarity and improved tooltip handling. - Cleaned up test files for `RdsCompTextEditor` and `RdsCompVideoPlayer` to remove outdated mocks and comments.
…ructure stories - Introduced sample columns and data for RdsCompGrid to enhance story demonstration. - Added commented-out structure for RdsCompTreeStructure to provide a clearer example of usage. - Improved documentation within stories for better understanding of component functionalities.
…p-Inventory Fixed Bug: Prop Typing and Component API Consistency Across Raaghu Design System
…dit-fixes-phase-1' into user/sagar/bug-raaghu-design-system-code-optimization
…design-system-code-optimization Completed Task : Refactor(components): enhance prop handling and update tests for RdsComponents and RdsElements.
…ponents - Updated prop names from `colorVariant` to `color` in multiple components for consistency with MUI standards. - Introduced deprecation warnings for legacy prop names to guide users towards the new naming conventions. - Enhanced documentation in `CONTRIBUTING.md` to clarify prop naming conventions and usage. - Improved Storybook configurations to sanitize ReactNode args and disable unnecessary object editors. - Adjusted tests to reflect the updated prop names and ensure compatibility with the new API structure.
…n - Moved MUI and Emotion packages from runtime dependencies to peerDependencies to ensure consuming applications manage their own versions. - Updated `npm run type-check` to run against `tsconfig.library.json` for consistency. - Excluded specific files from the published npm tarball to streamline package size. - Removed obsolete type definitions and improved MUI Alert contrast for better accessibility. - Consolidated MUI theme handling into a single `raaghuTheme` with support for light/dark modes and CSS variables.
…ed unnecessary `!important` flags from SCSS for cleaner styling. - Updated `RdsAppBar` component to support new `sx` prop for style overrides. - Improved test cases to validate new styling behavior and component variants. - Introduced CSS variables for app bar theming to simplify dark/light mode handling.
- Updated chart stories to use the new data prop structure. - Enabled editable data and options controls in Storybook. - Hid deprecated props from Storybook documentation. - Preserved existing chart datasets and configurations.
…dit-fixes-phase-2' into user/shivani/Bug-Chart-stories-prop-migration
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Important Review skippedToo many files! This PR contains 544 files, which is 444 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files.
 |
Collaborator
Author
|
wrong PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve the issues on:
dataprop structure instead of legacylabelsanddataSetsprops.dataandoptionsto support editing chart data and configurations.Checklist