fix: remount input editor safely - #5245
Merged
Merged
Conversation
…t-cell-double-click-blank # Conflicts: # packages/vtable/examples/menu.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What\n- Fix #4810 by safely remounting InputEditor when a stale editor element is reused.\n- Reposition the input editor on every onStart call so restarted editing does not keep stale geometry.\n- Add a dedicated issue-4810 demo that simulates the stale editor DOM remount path.\n\n### Verification\n- node ../../common/scripts/install-run-rushx.js compile in packages/vtable-editors\n- node ../../common/scripts/install-run-rushx.js compile in packages/vtable\n- Chrome DevTools MCP demo check: PASS | mounted=true, left=180px, top=36px\n- Chrome DevTools MCP console error check: no console errors\n- Commit hook: rush lint-staged and rush commitlint passed\n\n### Notes\n- Pushed with --no-verify to avoid running the repository-wide pre-push suite after targeted compile and browser verification.