Skip to content

fix: refresh functional icons after theme updates with demo - #5240

Merged
fangsmile merged 2 commits into
developfrom
review/pr5238-issue4816-verify
Jul 27, 2026
Merged

fix: refresh functional icons after theme updates with demo#5240
fangsmile merged 2 commits into
developfrom
review/pr5238-issue4816-verify

Conversation

@fangsmile

Copy link
Copy Markdown
Contributor

Summary

Issue

Fixes #4816

Demo

  • packages/vtable/examples/debug/issue-4816-functional-icons-theme.ts
  • Menu entry: Debug / issue-4816-functional-icons-theme
  • Flow: create table with initial functionalIconsStyle, call updateOption with new colors, check helper icon SVG caches

Verification

Review

  • Reviewed BaseTable theme update paths, helper icon cache refresh methods, and regression tests
  • Found and fixed one release metadata issue: production @visactor/vtable code changed but changeset type was none; updated it to patch
  • No remaining blocking logic/regression issues found

Note

  • Focused Jest commands were attempted, but direct package Jest processes stayed running without output in this local worktree environment. Page reproduction and TypeScript compile passed.

@fangsmile
fangsmile merged commit 9dcf6e2 into develop Jul 27, 2026
7 of 8 checks passed
@fangsmile
fangsmile deleted the review/pr5238-issue4816-verify branch July 27, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 修改主题中的functionalIconsStyle 配置后,updateOption后,图标的颜色没有生效

2 participants