fix: normalize Lynx text metrics - #2114
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
measureText()ascent/descent metrics instead of discarding themRoot cause
The Lynx context previously returned only text width and forced VRender to estimate ascent/descent with fixed font-size ratios. That made text layout diverge from browser Canvas while symbols retained the expected coordinates.
Impact
Lynx text layout can use native font metrics, keeping Tooltip text aligned without VChart- or Tooltip-specific offsets. Unsupported metrics still fall through to VRender's existing fallback behavior.
Validation
rushx test --runInBand __tests__/unit/lynx-context.test.tsrushx compileinpackages/vrender-kits