✨ Add TBytes32Stack to LibTransient (issue #1185)#1542
Open
BhariGowda wants to merge 1 commit into
Open
Conversation
Gas Snapshot Comparison Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1185
Adds
TBytes32Stacka transient storage value stack forbytes32.Unlike
TStack(which generates typed pointers), this stores values directly.API
tBytes32Stack(bytes32/uint256)→ pointerpush(ptr, bytes32)store valuepop(ptr)→ remove and return top (reverts if empty)top(ptr)→ peek top (reverts if empty)top(ptr, uint256 i)→ i-th from top, 0=topsize(ptr)→ element countclear(ptr)→ reset stackDesign
StackIsEmptyerror_STACK_BASE_SALT * slot + ((i+1) << 32)Tests
7 new tests concrete, fuzz, collision, 3 revert cases
Run:
FOUNDRY_PROFILE=post_osaka forge test --match-path test/LibTransient.t.sol29 passed, 0 failed