Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #452.
In relay-only mode, native ICE still tests host sockets against peer relay candidates. A TURN server drops those direct checks, and with multiple interfaces they can delay the usable relay pairs until the connection times out.
Skip host-socket candidates when the permitted candidate types contain only relay candidates. Add a regression case with two symmetric-NAT adapters per peer.
The candidate guard follows the fix proposed by @easymod0 in #452.
Verification:
test_p2pwith CMake/MSVC Debug, native ICE enabled and WebRTC disabled.--repeat=2.git diff --checkpassed.