Skip to content

Dump container logs and health probes on healthcheck failure#3148

Merged
adamtheturtle merged 2 commits intomainfrom
adamtheturtle/issue-3147
May 7, 2026
Merged

Dump container logs and health probes on healthcheck failure#3148
adamtheturtle merged 2 commits intomainfrom
adamtheturtle/issue-3147

Conversation

@adamtheturtle
Copy link
Copy Markdown
Member

@adamtheturtle adamtheturtle commented May 7, 2026

Summary

Test plan

  • Existing test_build_and_run still passes locally / in CI
  • On a forced failure, the error message includes container logs and probe entries

🤖 Generated with Claude Code


Note

Low Risk
Low risk: test-only change that augments failure diagnostics without altering production behavior; main risk is noisier CI output or unexpected decode/attr edge cases when containers lack health log data.

Overview
When wait_for_health_check exhausts retries in tests/mock_vws/test_docker.py, it now re-raises with additional diagnostics: the container’s logs and Docker State.Health.Log probe history.

The retrying poll logic is split into _poll_health_check (tenacity-decorated) plus a wrapper that formats and chains the enriched ValueError for easier CI debugging.

Reviewed by Cursor Bugbot for commit 5e1fda3. Bugbot is set up for automated code reviews on this repo. Configure here.

Closes #3147

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_build_and_run: dump container logs and Health.Log on healthcheck failure

1 participant