Dump container logs and health probes on healthcheck failure#3148
Merged
adamtheturtle merged 2 commits intomainfrom May 7, 2026
Merged
Dump container logs and health probes on healthcheck failure#3148adamtheturtle merged 2 commits intomainfrom
adamtheturtle merged 2 commits intomainfrom
Conversation
Closes #3147 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait_for_health_checkexhausts its retries intests/mock_vws/test_docker.py, it now augments the raisedValueErrorwith the container's logs and Docker'sState.Health.Logprobe history so CI failures are diagnosable rather than just reportingunhealthy.Test plan
test_build_and_runstill passes locally / in CI🤖 Generated with Claude Code
Note
Low Risk
Low risk: test-only change that augments failure diagnostics without altering production behavior; main risk is noisier CI output or unexpected decode/attr edge cases when containers lack health log data.
Overview
When
wait_for_health_checkexhausts retries intests/mock_vws/test_docker.py, it now re-raises with additional diagnostics: the container’s logs and DockerState.Health.Logprobe history.The retrying poll logic is split into
_poll_health_check(tenacity-decorated) plus a wrapper that formats and chains the enrichedValueErrorfor easier CI debugging.Reviewed by Cursor Bugbot for commit 5e1fda3. Bugbot is set up for automated code reviews on this repo. Configure here.