Skip to content

pref: add proxies kwargs in duckduckgo tool run func #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cavities wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pref: add proxies kwargs in duckduckgo tool run func #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions promptulate/tools/duckduckgo/api_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class DuckDuckGoSearchAPIWrapper(BaseModel):
safe_search: str = "moderate"
time: Optional[str] = "y"
max_num_of_results: int = 5

proxies: Optional[str] = None
class Config:
"""Configuration for this pydantic object."""

Expand All @@ -37,7 +37,7 @@ def query(
if not num_results:
num_results = self.max_num_of_results

with DDGS() as ddgs:
with DDGS(self.proxies) as ddgs:

@Undertone0809 Undertone0809 May 20, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duckduckgo_search==3.9.11 defines DDGS(headers=None, proxies=None, timeout=10), so DDGS(self.proxies) binds the proxy string to headers, not proxies. This means the proxy is never applied. Please pass it explicitly as DDGS(proxies=self.proxies) here and in the other call site.

results = ddgs.text(
keyword,
region=self.region,
Expand Down Expand Up @@ -74,7 +74,7 @@ def query_by_formatted_results(
if not num_results:
num_results = self.max_num_of_results

with DDGS() as ddgs:
with DDGS(self.proxies) as ddgs:
results = ddgs.text(
query,
region=self.region,
Expand Down
7 changes: 6 additions & 1 deletion promptulate/tools/duckduckgo/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ def _run(self, keyword: str, **kwargs) -> Union[str, List[str]]:
result_type="original"
"""
from duckduckgo_search.exceptions import RateLimitException

if "proxies" in kwargs:

@Undertone0809 Undertone0809 May 20, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mutates self.api_wrapper.proxies only when kwargs["proxies"] is truthy, so once one call sets a proxy, later calls on the same tool instance will keep using that stale proxy unless the process is restarted. It also makes proxies=None unable to clear the setting. Please thread proxies through per call, or at least assign self.api_wrapper.proxies = kwargs.get("proxies") before the query.

if kwargs["proxies"]:
self.api_wrapper.proxies = kwargs["proxies"]
attempt = 0
while attempt < self.max_retry:
try:
Expand Down Expand Up @@ -80,6 +82,9 @@ def _run(self, keyword: str, **kwargs) -> Union[str, List[Dict[str, str]]]:
default is string. Return List[Dict[str, str]] type data if you pass
result_type="original"
"""
if "proxies" in kwargs:
if kwargs["proxies"]:
self.api_wrapper.proxies = kwargs["proxies"]
result = self.api_wrapper.query_by_formatted_results(keyword, **kwargs)
if "return_type" in kwargs and kwargs["return_type"] == "original":
return result
Expand Down